[Ops] update causal_conv1d_update#5984
Merged
wangxiyuan merged 5 commits intovllm-project:mainfrom Jan 21, 2026
Merged
Conversation
Signed-off-by: SunnyLee219 <3294305115@qq.com>
SunnyLee151064
requested review from
realliujiaxu and
zzzzwwjj
as code owners
Contributor
|
👋 Hi! Thank you for contributing to the vLLM Ascend project. The following points will speed up your PR merge:
If CI fails, you can run linting and testing checks locally according Contributing and Testing. |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the causal_conv1d_update operation for better performance by changing the data layout of several tensors (weight, conv_state, x) to be more cache-friendly for the Triton kernel. The changes throughout the causal_conv1d_update_npu function are consistent with these new data layouts. My main feedback is to remove a leftover debugging print statement.
| out: (batch, dim) or (batch, dim, seqlen) or (num_tokens, dim), same shape as `x` | ||
| """ | ||
| weight = weight.transpose(0, 1).contiguous() | ||
| print("weight's shape: ", weight.size()) |
Contributor
There was a problem hiding this comment.
This print statement appears to be a debugging artifact. It should be removed before merging to avoid polluting logs and to prevent potential performance degradation in production environments, as I/O operations can be costly.
Signed-off-by: SunnyLee219 <3294305115@qq.com>
wangxiyuan
added
ready
auto-merge was automatically disabled
January 21, 2026 03:34
Head branch was pushed to by a user without write access
845473182
pushed a commit
to 845473182/vllm-ascend
that referenced
this pull request
Jan 22, 2026
…to FIA_rebase * 'main' of https://github.com/vllm-project/vllm-ascend: [CI] Upgrade CANN to 8.5.0 (vllm-project#6070) Default enable MLAPO (vllm-project#5952) [Doc] Supplement PD separation parameters of DeepSeek V3.1 (vllm-project#6053) [Ascend] perf: optimize rope embedding with triton kernel for huge performance gain (vllm-project#5918) [Ops] update causal_conv1d_update (vllm-project#5984) [CI]Update triton ascend version in 3.2.0 (vllm-project#6067) [bugfix] fix the complex and potentially problematic generate_kv_idx. (vllm-project#5957)
starmountain1997
pushed a commit
to starmountain1997/vllm-ascend
that referenced
this pull request
Jan 31, 2026
### What this PR does / why we need it? Update causal_conv1d_update ops for better perf. - vLLM version: v0.13.0 - vLLM main: vllm-project/vllm@2c24bc6 --------- Signed-off-by: SunnyLee219 <3294305115@qq.com>
ZRJ026
pushed a commit
to ZRJ026/vllm-ascend
that referenced
this pull request
Feb 28, 2026
### What this PR does / why we need it? Update causal_conv1d_update ops for better perf. - vLLM version: v0.13.0 - vLLM main: vllm-project/vllm@2c24bc6 --------- Signed-off-by: SunnyLee219 <3294305115@qq.com> Signed-off-by: zrj026 <zhangrunjiang026@gmail.com>
maoxx241
pushed a commit
to maoxx241/vllm-ascend
that referenced
this pull request
Mar 2, 2026
### What this PR does / why we need it? Update causal_conv1d_update ops for better perf. - vLLM version: v0.13.0 - vLLM main: vllm-project/vllm@2c24bc6 --------- Signed-off-by: SunnyLee219 <3294305115@qq.com>
ZRJ026
pushed a commit
to ZRJ026/vllm-ascend
that referenced
this pull request
Mar 4, 2026
### What this PR does / why we need it? Update causal_conv1d_update ops for better perf. - vLLM version: v0.13.0 - vLLM main: vllm-project/vllm@2c24bc6 --------- Signed-off-by: SunnyLee219 <3294305115@qq.com> Signed-off-by: zrj026 <zhangrunjiang026@gmail.com>
LCAIZJ
pushed a commit
to LCAIZJ/vllm-ascend
that referenced
this pull request
Mar 7, 2026
### What this PR does / why we need it? Update causal_conv1d_update ops for better perf. - vLLM version: v0.13.0 - vLLM main: vllm-project/vllm@2c24bc6 --------- Signed-off-by: SunnyLee219 <3294305115@qq.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it?
Update causal_conv1d_update ops for better perf.
Does this PR introduce any user-facing change?
How was this patch tested?