[CI] update triton-ascend version#5584
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the environment setup command for the Ascend BiSheng toolkit in two tutorial documents. My review identifies a potential issue with this change: replacing a source command with an export PATH command may lead to an incomplete environment configuration, which could cause problems for users. I've left specific comments on the affected lines. Additionally, the pull request description mentions updating to version 20260104, but this version is not present in the changes, which could be confusing.
| BISHENG_URL="https://vllm-ascend.obs.cn-north-4.myhuaweicloud.com/vllm-ascend/${BISHENG_NAME}" | ||
| wget -O "${BISHENG_NAME}" "${BISHENG_URL}" && chmod a+x "${BISHENG_NAME}" && "./${BISHENG_NAME}" --install && rm "${BISHENG_NAME}" | ||
| source /usr/local/Ascend/8.5.0/bisheng_toolkit/set_env.sh | ||
| export PATH=/usr/local/Ascend/tools/bishengir/bin:$PATH |
There was a problem hiding this comment.
This change from sourceing a setup script to just exporting a PATH is risky. The original set_env.sh script likely configured other essential environment variables (e.g., LD_LIBRARY_PATH) besides PATH. The new command only sets the PATH, which could lead to an incomplete environment and cause runtime errors for users following this tutorial. If the new toolkit provides a setup script, it should be sourced to ensure a complete and correct environment setup.
| BISHENG_URL="https://vllm-ascend.obs.cn-north-4.myhuaweicloud.com/vllm-ascend/${BISHENG_NAME}" | ||
| wget -O "${BISHENG_NAME}" "${BISHENG_URL}" && chmod a+x "${BISHENG_NAME}" && "./${BISHENG_NAME}" --install && rm "${BISHENG_NAME}" | ||
| source /usr/local/Ascend/8.5.0/bisheng_toolkit/set_env.sh | ||
| export PATH=/usr/local/Ascend/tools/bishengir/bin:$PATH |
There was a problem hiding this comment.
This change from sourceing a setup script to just exporting a PATH is risky. The original set_env.sh script likely configured other essential environment variables (e.g., LD_LIBRARY_PATH) besides PATH. The new command only sets the PATH, which could lead to an incomplete environment and cause runtime errors for users following this tutorial. If the new toolkit provides a setup script, it should be sourced to ensure a complete and correct environment setup.
Meihan-chen
force-pushed
the
triton_ver
branch
from
7910cc1 to
82e91f8
Compare
| source /usr/local/Ascend/8.5.0/bisheng_toolkit/set_env.sh | ||
| python3 -m pip install "https://vllm-ascend.obs.cn-north-4.myhuaweicloud.com/vllm-ascend/triton_ascend-3.2.0.dev20251229-cp311-cp311-manylinux_2_27_aarch64.manylinux_2_28_aarch64.whl" | ||
| export PATH=/usr/local/Ascend/tools/bishengir/bin:$PATH | ||
| pip install -i https://test.pypi.org/simple/ triton-ascend==3.2.0.dev20260104 |
There was a problem hiding this comment.
plz use the obs source if this version is okay
MengqingCao
added
ready
|
The doc also need to be updated |
|
👋 Hi! Thank you for contributing to the vLLM Ascend project. The following points will speed up your PR merge:
If CI fails, you can run linting and testing checks locally according Contributing and Testing. |
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
|
All check has passed in triton-ascend ver 20260103 https://github.com/vllm-project/vllm-ascend/actions/runs/20691318391/job/59399890838 |
Signed-off-by: Meihan-chen <jcccx.cmh@gmail.com>
Signed-off-by: Meihan-chen <jcccx.cmh@gmail.com>
Meihan-chen
force-pushed
the
triton_ver
branch
from
124f526 to
335043e
Compare
### What this PR does / why we need it? update triton-ascend version to 20260105 - vLLM version: v0.13.0 - vLLM main: vllm-project/vllm@7157596 --------- Signed-off-by: Meihan-chen <jcccx.cmh@gmail.com>
…to FIA_rebase * 'main' of https://github.com/vllm-project/vllm-ascend: (58 commits) [Main2Main] Upgrade vllm commit to 0106 (vllm-project#5617) [CI]update bisheng version (vllm-project#5621) [UT][PCP&DCP] UT for block_table.py (vllm-project#5032) [Main2Main] Upgrade vllm commit to 0105 (vllm-project#5595) [CI] mv ops to correct path (vllm-project#5615) [BugFix] Fix Smoke Testing Bug for DSR1 longseq (vllm-project#5613) Revert "[Feat] enable hierarchical mc2 ops on A2 by default (vllm-project#5545)" (vllm-project#5611) [TRITON][TEST]Add nightly test for triton split_qkv_rmsnorm_rope (vllm-project#5267) [perf] Fix MLAPO weight disposal for KV-consumer MLA in PD-mix deploy... (vllm-project#5192) [docs] Correct image about prefill phase of PCP (vllm-project#5598) [CI] update triton-ascend version (vllm-project#5584) [P/D]Remove mooncake kvpool unused parameter `local_hostname` (vllm-project#5574) [Bugfix] record cos and sin cache in AscendRotaryEmbedding (vllm-project#5516) [bugfix] fix test_camem failed with triton-ascend (vllm-project#5492) [UT]add triton ops ut : test_fused_qkvzba_split_reshape_cat (vllm-project#5474) [CI] Download models from ms (vllm-project#5405) Docs: Add A3 Docker image guidance for Atlas A3 machines (vllm-project#5256) [Doc] Add NNAL installation guide and requirements (vllm-project#5235) Add the requirement of arctic-inference which speculative decoding with suffix_decode (vllm-project#5045) [BugFix][Fusion] Fix graph fusion failure problem (vllm-project#5253) ...
### What this PR does / why we need it? update triton-ascend version to 20260105 - vLLM version: v0.13.0 - vLLM main: vllm-project/vllm@7157596 --------- Signed-off-by: Meihan-chen <jcccx.cmh@gmail.com>
### What this PR does / why we need it? update triton-ascend version to 20260105 - vLLM version: v0.13.0 - vLLM main: vllm-project/vllm@7157596 --------- Signed-off-by: Meihan-chen <jcccx.cmh@gmail.com>
### What this PR does / why we need it? update triton-ascend version to 20260105 - vLLM version: v0.13.0 - vLLM main: vllm-project/vllm@7157596 --------- Signed-off-by: Meihan-chen <jcccx.cmh@gmail.com> Signed-off-by: zrj026 <zhangrunjiang026@gmail.com>
### What this PR does / why we need it? update triton-ascend version to 20260105 - vLLM version: v0.13.0 - vLLM main: vllm-project/vllm@7157596 --------- Signed-off-by: Meihan-chen <jcccx.cmh@gmail.com>
### What this PR does / why we need it? update triton-ascend version to 20260105 - vLLM version: v0.13.0 - vLLM main: vllm-project/vllm@7157596 --------- Signed-off-by: Meihan-chen <jcccx.cmh@gmail.com> Signed-off-by: zrj026 <zhangrunjiang026@gmail.com>
### What this PR does / why we need it? update triton-ascend version to 20260105 - vLLM version: v0.13.0 - vLLM main: vllm-project/vllm@7157596 --------- Signed-off-by: Meihan-chen <jcccx.cmh@gmail.com>
3 participants
What this PR does / why we need it?
update triton-ascend version to 20260105
Does this PR introduce any user-facing change?
How was this patch tested?