[Test][Accuracy] Add accuracy evaluation config for InternVL3_5-8B#3964
Merged
MengqingCao merged 1 commit intovllm-project:mainfrom Nov 12, 2025
Merged
[Test][Accuracy] Add accuracy evaluation config for InternVL3_5-8B#3964MengqingCao merged 1 commit intovllm-project:mainfrom
MengqingCao merged 1 commit intovllm-project:mainfrom
Conversation
Contributor
|
👋 Hi! Thank you for contributing to the vLLM Ascend project. The following points will speed up your PR merge:
If CI fails, you can run linting and testing checks locally according Contributing and Testing. |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request adds a new test configuration file to evaluate the accuracy of the InternVL3_5-8B model. While the configuration is straightforward and appears to serve its purpose, it introduces a critical security vulnerability by enabling trust_remote_code. This setting can lead to arbitrary code execution in the CI environment. My review includes a critical comment detailing this risk and suggesting potential mitigations.
Contributor
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
gcanlin
force-pushed
the
acc-internvl3_5
branch
from
088b748 to
ed28694
Compare
Signed-off-by: gcanlin <canlinguosdu@gmail.com>
gcanlin
force-pushed
the
acc-internvl3_5
branch
from
ed28694 to
2afecee
Compare
MengqingCao
added
ready
Collaborator
Author
|
@MengqingCao CI has passed. Could you please merge this PR? |
luolun
pushed a commit
to luolun/vllm-ascend
that referenced
this pull request
Nov 19, 2025
…llm-project#3964) ### What this PR does / why we need it? To continuously monitor the accuracy of the InternVL3_5-8B model, this PR adds the corresponding configuration file to the CI. We need to add the `-hf` suffix to avoid incompatibility with the `lm-eval` preprocessor. ### How was this patch tested? `pytest -sv ./tests/e2e/models/test_lm_eval_correctness.py --config ./tests/e2e/models/configs/InternVL3_5-8B.yaml` - vLLM version: v0.11.0 - vLLM main: vllm-project/vllm@83f478b Signed-off-by: gcanlin <canlinguosdu@gmail.com> Signed-off-by: luolun <luolun1995@cmbchina.com>
hwhaokun
pushed a commit
to hwhaokun/vllm-ascend
that referenced
this pull request
Nov 19, 2025
…llm-project#3964) ### What this PR does / why we need it? To continuously monitor the accuracy of the InternVL3_5-8B model, this PR adds the corresponding configuration file to the CI. We need to add the `-hf` suffix to avoid incompatibility with the `lm-eval` preprocessor. ### How was this patch tested? `pytest -sv ./tests/e2e/models/test_lm_eval_correctness.py --config ./tests/e2e/models/configs/InternVL3_5-8B.yaml` - vLLM version: v0.11.0 - vLLM main: vllm-project/vllm@83f478b Signed-off-by: gcanlin <canlinguosdu@gmail.com> Signed-off-by: hwhaokun <haokun0405@163.com>
NSDie
pushed a commit
to NSDie/vllm-ascend
that referenced
this pull request
Nov 24, 2025
…llm-project#3964) ### What this PR does / why we need it? To continuously monitor the accuracy of the InternVL3_5-8B model, this PR adds the corresponding configuration file to the CI. We need to add the `-hf` suffix to avoid incompatibility with the `lm-eval` preprocessor. ### How was this patch tested? `pytest -sv ./tests/e2e/models/test_lm_eval_correctness.py --config ./tests/e2e/models/configs/InternVL3_5-8B.yaml` - vLLM version: v0.11.0 - vLLM main: vllm-project/vllm@83f478b Signed-off-by: gcanlin <canlinguosdu@gmail.com> Signed-off-by: nsdie <yeyifan@huawei.com>
Clorist33
pushed a commit
to Clorist33/vllm-ascend
that referenced
this pull request
Dec 10, 2025
…llm-project#3964) ### What this PR does / why we need it? To continuously monitor the accuracy of the InternVL3_5-8B model, this PR adds the corresponding configuration file to the CI. We need to add the `-hf` suffix to avoid incompatibility with the `lm-eval` preprocessor. ### How was this patch tested? `pytest -sv ./tests/e2e/models/test_lm_eval_correctness.py --config ./tests/e2e/models/configs/InternVL3_5-8B.yaml` - vLLM version: v0.11.0 - vLLM main: vllm-project/vllm@83f478b Signed-off-by: gcanlin <canlinguosdu@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it?
To continuously monitor the accuracy of the InternVL3_5-8B model, this PR adds the corresponding configuration file to the CI. We need to add the
-hfsuffix to avoid incompatibility with thelm-evalpreprocessor.Does this PR introduce any user-facing change?
None.
How was this patch tested?
pytest -sv ./tests/e2e/models/test_lm_eval_correctness.py --config ./tests/e2e/models/configs/InternVL3_5-8B.yaml