Skip to content

[Docs] Add InternVL series tutorial for single NPU#3664

Closed
gcanlin wants to merge 4 commits intovllm-project:mainfrom
gcanlin:internvl-docs
Closed

[Docs] Add InternVL series tutorial for single NPU#3664
gcanlin wants to merge 4 commits intovllm-project:mainfrom
gcanlin:internvl-docs

Conversation

@gcanlin
Copy link
Copy Markdown
Collaborator

@gcanlin gcanlin commented Oct 23, 2025

What this PR does / why we need it?

Closes #3508.

Does this PR introduce any user-facing change?

No.

How was this patch tested?

No need to test. All scripts and Python code in the docs has been tested.

Signed-off-by: gcanlin <canlinguosdu@gmail.com>
@github-actions
Copy link
Copy Markdown
Contributor

👋 Hi! Thank you for contributing to the vLLM Ascend project. The following points will speed up your PR merge:‌‌

  • A PR should do only one thing, smaller PRs enable faster reviews.
  • Every PR should include unit tests and end-to-end tests ‌to ensure it works and is not broken by other future PRs.
  • Write the commit message by fulfilling the PR description to help reviewer and future developers understand.

If CI fails, you can run linting and testing checks locally according Contributing and Testing.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds a new tutorial for running InternVL series models on a single NPU. The tutorial is well-structured and provides clear instructions for both offline inference and online serving. However, there is a significant issue with the model path used in the examples, which points to a non-public model. This will prevent users from following the tutorial. My review includes a comment to address this.

Comment thread docs/source/tutorials/single_npu_internvl.md
Signed-off-by: gcanlin <canlinguosdu@gmail.com>
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Oct 23, 2025
Signed-off-by: gcanlin <canlinguosdu@gmail.com>
Signed-off-by: gcanlin <canlinguosdu@gmail.com>
@Yikun
Copy link
Copy Markdown
Member

Yikun commented Oct 24, 2025

Please add an accuracy test with same parameter with doc before merge.

https://github.com/vllm-project/vllm-ascend/tree/main/tests%2Fe2e%2Fmodels%2Fconfigs

@github-actions
Copy link
Copy Markdown
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

wangxiyuan pushed a commit that referenced this pull request Oct 31, 2025
### What this PR does / why we need it?

As a validation for #3664, add end-to-end tests to monitor the InternVL
model and ensure its continuous proper operation. This PR is only for
single-card. So the models that have more parameters than 8B like 78B
are needed to test using multi-cards.
 

### Does this PR introduce _any_ user-facing change?

None.

### How was this patch tested?

`pytest -sv tests/e2e/singlecard/multi-modal/test_internvl.py`


- vLLM version: v0.11.0
- vLLM main:
vllm-project/vllm@83f478b

---------

Signed-off-by: gcanlin <canlinguosdu@gmail.com>
]

# Same image for all prompts
images = [image] * len(prompts)
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This images variable is not used, should it be deleted?

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the late response. It seems that I lost some code here. I will complete it later. Thanks!

@gcanlin
Copy link
Copy Markdown
Collaborator Author

gcanlin commented Nov 14, 2025

Now the e2e test(#3796, InternVL2, InternVL2_5, InternVL3, InternVL3_5) and accuracy/correctness test(#3964, only InternVL3 for now because of the limit of resources, maybe we should add more models in future). I will reconstruct this doc referring to the new docs of DeepseekV3.2.

luolun pushed a commit to luolun/vllm-ascend that referenced this pull request Nov 19, 2025
### What this PR does / why we need it?

As a validation for vllm-project#3664, add end-to-end tests to monitor the InternVL
model and ensure its continuous proper operation. This PR is only for
single-card. So the models that have more parameters than 8B like 78B
are needed to test using multi-cards.
 

### Does this PR introduce _any_ user-facing change?

None.

### How was this patch tested?

`pytest -sv tests/e2e/singlecard/multi-modal/test_internvl.py`


- vLLM version: v0.11.0
- vLLM main:
vllm-project/vllm@83f478b

---------

Signed-off-by: gcanlin <canlinguosdu@gmail.com>
Signed-off-by: luolun <luolun1995@cmbchina.com>
hwhaokun pushed a commit to hwhaokun/vllm-ascend that referenced this pull request Nov 19, 2025
### What this PR does / why we need it?

As a validation for vllm-project#3664, add end-to-end tests to monitor the InternVL
model and ensure its continuous proper operation. This PR is only for
single-card. So the models that have more parameters than 8B like 78B
are needed to test using multi-cards.

### Does this PR introduce _any_ user-facing change?

None.

### How was this patch tested?

`pytest -sv tests/e2e/singlecard/multi-modal/test_internvl.py`

- vLLM version: v0.11.0
- vLLM main:
vllm-project/vllm@83f478b

---------

Signed-off-by: gcanlin <canlinguosdu@gmail.com>
Signed-off-by: hwhaokun <haokun0405@163.com>
NSDie pushed a commit to NSDie/vllm-ascend that referenced this pull request Nov 24, 2025
### What this PR does / why we need it?

As a validation for vllm-project#3664, add end-to-end tests to monitor the InternVL
model and ensure its continuous proper operation. This PR is only for
single-card. So the models that have more parameters than 8B like 78B
are needed to test using multi-cards.

### Does this PR introduce _any_ user-facing change?

None.

### How was this patch tested?

`pytest -sv tests/e2e/singlecard/multi-modal/test_internvl.py`

- vLLM version: v0.11.0
- vLLM main:
vllm-project/vllm@83f478b

---------

Signed-off-by: gcanlin <canlinguosdu@gmail.com>
Signed-off-by: nsdie <yeyifan@huawei.com>
Clorist33 pushed a commit to Clorist33/vllm-ascend that referenced this pull request Dec 10, 2025
### What this PR does / why we need it?

As a validation for vllm-project#3664, add end-to-end tests to monitor the InternVL
model and ensure its continuous proper operation. This PR is only for
single-card. So the models that have more parameters than 8B like 78B
are needed to test using multi-cards.
 

### Does this PR introduce _any_ user-facing change?

None.

### How was this patch tested?

`pytest -sv tests/e2e/singlecard/multi-modal/test_internvl.py`


- vLLM version: v0.11.0
- vLLM main:
vllm-project/vllm@83f478b

---------

Signed-off-by: gcanlin <canlinguosdu@gmail.com>
@wangxiyuan
Copy link
Copy Markdown
Collaborator

Any progress? If this PR is still alive, please rebase to main and make CI happy. Thanks

@gcanlin
Copy link
Copy Markdown
Collaborator Author

gcanlin commented Jan 5, 2026

Any progress? If this PR is still alive, please rebase to main and make CI happy. Thanks

YES, I will refactor this PR later, maybe will need about 2 days.

@shen-shanshan shen-shanshan mentioned this pull request Jan 13, 2026
28 tasks
@Yikun
Copy link
Copy Markdown
Member

Yikun commented Mar 1, 2026

Any progress?

@wangxiyuan
Copy link
Copy Markdown
Collaborator

Please rebase and fix the merge conflicts

@wangxiyuan
Copy link
Copy Markdown
Collaborator

no update for long time, close this now. Feel free to reopen if it's still needed.

@wangxiyuan wangxiyuan closed this Apr 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation merge-conflicts

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[RFC]: Multi-Modal Tasks

4 participants