[Platform] Add import_kernels interface #3694
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👋 Hi! Thank you for contributing to the vLLM Ascend project. The following points will speed up your PR merge:
If CI fails, you can run linting and testing checks locally according Contributing and Testing. |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces a new import_kernels interface to the NPUPlatform class. My review identifies a significant issue of code duplication. The new method's implementation is nearly identical to the existing enable_custom_op function in vllm_ascend/utils.py. This duplication increases maintenance overhead and could lead to inconsistencies. I've suggested refactoring the new method to reuse the existing function, which also benefits from caching logic that the new implementation lacks.
Collaborator
|
we make custom_ops lazy load here #884 please consider this case. |
Signed-off-by: gcanlin <[email protected]>
Signed-off-by: gcanlin <[email protected]>
Signed-off-by: gcanlin <[email protected]>
Signed-off-by: gcanlin <[email protected]>
wangxiyuan
approved these changes
Nov 13, 2025
wangxiyuan
added
ready
luolun
pushed a commit
to luolun/vllm-ascend
that referenced
this pull request
Nov 19, 2025
### What this PR does / why we need it? Add import_kernels interface to avoid import useless vLLM C library Closes vllm-project#3488. Reopen vllm-project#3498 for CI. ### How was this patch tested? CI tested. - vLLM version: v0.11.0 - vLLM main: vllm-project/vllm@2918c1b --------- Signed-off-by: gcanlin <[email protected]> Signed-off-by: luolun <[email protected]>
hwhaokun
pushed a commit
to hwhaokun/vllm-ascend
that referenced
this pull request
Nov 19, 2025
### What this PR does / why we need it? Add import_kernels interface to avoid import useless vLLM C library Closes vllm-project#3488. Reopen vllm-project#3498 for CI. ### How was this patch tested? CI tested. - vLLM version: v0.11.0 - vLLM main: vllm-project/vllm@2918c1b --------- Signed-off-by: gcanlin <[email protected]> Signed-off-by: hwhaokun <[email protected]>
NSDie
pushed a commit
to NSDie/vllm-ascend
that referenced
this pull request
Nov 24, 2025
### What this PR does / why we need it? Add import_kernels interface to avoid import useless vLLM C library Closes vllm-project#3488. Reopen vllm-project#3498 for CI. ### How was this patch tested? CI tested. - vLLM version: v0.11.0 - vLLM main: vllm-project/vllm@2918c1b --------- Signed-off-by: gcanlin <[email protected]> Signed-off-by: nsdie <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it?
Closes #3488. Reopen #3498 for CI.
Does this PR introduce any user-facing change?
How was this patch tested?
CI tested.