[Platform] Add import_kernels interface #3498
Conversation
|
👋 Hi! Thank you for contributing to the vLLM Ascend project. The following points will speed up your PR merge:
If CI fails, you can run linting and testing checks locally according Contributing and Testing. |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces the import_kernels method to the NPUPlatform class, aligning it with an updated interface from the upstream vLLM project. The implementation correctly attempts to import the optional vllm._moe_C library for Mixture-of-Experts support, while gracefully handling an ImportError if the library is not available. This approach is consistent with how optional kernels are managed in other platform implementations within vLLM. The code is clean, correct, and follows best practices for handling optional dependencies. I have reviewed the changes and found no issues.
Signed-off-by: gcanlin <[email protected]>
|
@wangxiyuan Could you please take a look? Thanks! |
MengqingCao
added
ready
|
Closed for the stale CI. |
### What this PR does / why we need it? Add import_kernels interface to avoid import useless vLLM C library Closes #3488. Reopen #3498 for CI. ### How was this patch tested? CI tested. - vLLM version: v0.11.0 - vLLM main: vllm-project/vllm@2918c1b --------- Signed-off-by: gcanlin <[email protected]>
### What this PR does / why we need it? Add import_kernels interface to avoid import useless vLLM C library Closes vllm-project#3488. Reopen vllm-project#3498 for CI. ### How was this patch tested? CI tested. - vLLM version: v0.11.0 - vLLM main: vllm-project/vllm@2918c1b --------- Signed-off-by: gcanlin <[email protected]> Signed-off-by: luolun <[email protected]>
### What this PR does / why we need it? Add import_kernels interface to avoid import useless vLLM C library Closes vllm-project#3488. Reopen vllm-project#3498 for CI. ### How was this patch tested? CI tested. - vLLM version: v0.11.0 - vLLM main: vllm-project/vllm@2918c1b --------- Signed-off-by: gcanlin <[email protected]> Signed-off-by: hwhaokun <[email protected]>
### What this PR does / why we need it? Add import_kernels interface to avoid import useless vLLM C library Closes vllm-project#3488. Reopen vllm-project#3498 for CI. ### How was this patch tested? CI tested. - vLLM version: v0.11.0 - vLLM main: vllm-project/vllm@2918c1b --------- Signed-off-by: gcanlin <[email protected]> Signed-off-by: nsdie <[email protected]>
2 participants
What this PR does / why we need it?
Closes #3488.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
CI passed.