Skip to content

[Doc][Misc] Add deployment reference notice for GLM-5 - #12958

Merged
yiz-liu merged 2 commits into
vllm-project:mainfrom
wangzhishenghw:728
Aug 3, 2026
Merged

yiz-liu merged 2 commits into
vllm-project:mainfrom
wangzhishenghw:728

Conversation

@wangzhishenghw

@wangzhishenghw wangzhishenghw commented Jul 28, 2026

Copy link
Copy Markdown
Contributor

What this PR does / why we need it?

This PR adds a notice and a reference link to Chapter 5 (Online Service Deployment) in the GLM-5 tutorial. This helps users find complete startup commands and parameter descriptions, and reminds them to configure max-model-len and max-num-seqs according to their actual usage scenarios.

Does this PR introduce any user-facing change?

No, this is a documentation-only update.

How was this patch tested?

Documentation changes only, verified markdown rendering.

@gemini-code-assist

Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request updates the GLM5 tutorial documentation to provide clearer guidance on deployment parameters and references to the relevant configuration chapter, improving the user experience for those setting up the model.

Highlights

  • Documentation Update: Added a notice and reference link to the deployment section in the GLM5 tutorial documentation.
New Features

🧠 You can now enable Memory (public preview) to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the GLM-5 tutorial documentation by adding a notice and reference link to Chapter 5 (Online Service Deployment) to guide users on configuring max-model-len and max-num-seqs. The reviewer noted that the PR title and description do not adhere to the repository's Pull Request Summary Style Guide and provided a compliant template to use.

|High Throughput (A3)|1P1D deployment|32|P:8 D:4|P:4 D:8|P:64 D:128|P:4096 D:32|P:133120 D:150000|3|
|Low Latency (A3)|1P1D deployment|32|4|8|P:64 D:128|P:4096 D:32|P:133120 D:150000|3|

> For complete startup commands and parameter descriptions, please refer to the deployment examples in [Chapter 5](#5-online-service-deployment).

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The current Pull Request title and description do not follow the repository's Pull Request Summary Style Guide. Please update them to match the required format.\n\nSuggested PR Title:\n\nmarkdown\n[Doc][Misc] Add deployment reference notice for GLM-5\n\n\nSuggested PR Summary:\n\nmarkdown\n### What this PR does / why we need it?\n\nThis PR adds a notice and a reference link to Chapter 5 (Online Service Deployment) in the GLM-5 tutorial. This helps users find complete startup commands and parameter descriptions, and reminds them to configure `max-model-len` and `max-num-seqs` according to their actual usage scenarios.\n\n### Does this PR introduce _any_ user-facing change?\n\nNo, this is a documentation-only update.\n\n### How was this patch tested?\n\nDocumentation changes only, verified markdown rendering.\n

References
  1. The Pull Request title and summary must follow the specified format and be output in markdown code blocks. (link)

@github-actions github-actions Bot added the documentation Improvements or additions to documentation label Jul 28, 2026
@github-actions

Copy link
Copy Markdown
Contributor

👋 Hi! Thank you for contributing to the vLLM Ascend project. The following points will speed up your PR merge:‌‌

  • A PR should do only one thing, smaller PRs enable faster reviews.
  • Every PR should include unit tests and end-to-end tests ‌to ensure it works and is not broken by other future PRs.
  • Write the commit message by fulfilling the PR description to help reviewer and future developers understand.

If CI fails, you can run linting and testing checks locally according Contributing and Testing.

@wangzhishenghw wangzhishenghw changed the title v0 [Doc][Misc] Add deployment reference notice for GLM-5 Jul 28, 2026
@wangzhishenghw

wangzhishenghw commented Jul 28, 2026

Copy link
Copy Markdown
Contributor Author

/cherry-pick releases/v0.24.0rc
[Bot]: cherry-pick completed successfully. New PR created: #12961

@wangzhishenghw

wangzhishenghw commented Jul 28, 2026

Copy link
Copy Markdown
Contributor Author

/cherry-pick releases/v0.23.0
[Bot]: cherry-pick completed successfully. New PR created: #12960

@wangzhishenghw
wangzhishenghw force-pushed the 728 branch 2 times, most recently from 1e9f22e to 959b1c9 Compare July 30, 2026 02:00
Signed-off-by: wangzhishenghw <wangzhisheng6@h-partners.com>
@wangzhishenghw

wangzhishenghw commented Jul 30, 2026

Copy link
Copy Markdown
Contributor Author

/cherry-pick releases/v0.23.0
[Bot]: cherry-pick branch has been refreshed. Existing PR: #12960

@wangzhishenghw

wangzhishenghw commented Jul 30, 2026

Copy link
Copy Markdown
Contributor Author

/cherry-pick releases/v0.24.0rc
[Bot]: cherry-pick branch has been refreshed. Existing PR: #12961

vllm-ascend-ci pushed a commit to vllm-ascend-ci/vllm-ascend that referenced this pull request Jul 30, 2026
vllm-ascend-ci pushed a commit to vllm-ascend-ci/vllm-ascend that referenced this pull request Jul 30, 2026
Signed-off-by: wangzhishenghw <wangzhisheng6@h-partners.com>
@wangzhishenghw

wangzhishenghw commented Jul 30, 2026

Copy link
Copy Markdown
Contributor Author

/cherry-pick releases/v0.23.0
[Bot]: cherry-pick command failed. Please check the workflow run for details.

@wangzhishenghw

wangzhishenghw commented Jul 30, 2026

Copy link
Copy Markdown
Contributor Author

/cherry-pick releases/v0.24.0rc
[Bot]: cherry-pick branch has been refreshed. Existing PR: #12961

vllm-ascend-ci pushed a commit to vllm-ascend-ci/vllm-ascend that referenced this pull request Jul 30, 2026
@yiz-liu
yiz-liu merged commit c511ca4 into vllm-project:main Aug 3, 2026
16 checks passed
yiz-liu pushed a commit that referenced this pull request Aug 3, 2026
… notice for GLM-5 (from #12958) (#12961)

Cherry-pick of PR #12958 onto `releases/v0.24.0rc`.

Original PR: #12958
Original author: @wangzhishenghw

---
### What this PR does / why we need it?
This PR adds a notice and a reference link to Chapter 5 (Online Service
Deployment) in the GLM-5 tutorial. This helps users find complete
startup commands and parameter descriptions, and reminds them to
configure `max-model-len` and `max-num-seqs` according to their actual
usage scenarios.
### Does this PR introduce _any_ user-facing change?
No, this is a documentation-only update.
### How was this patch tested?
Documentation changes only, verified markdown rendering.

- vLLM version: v0.24.0
- vLLM main:
vllm-project/vllm@85c09e9

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
yiz-liu pushed a commit that referenced this pull request Aug 3, 2026
…otice for GLM-5 (from #12958) (#12960)

Cherry-pick of PR #12958 onto `releases/v0.23.0`.

Original PR: #12958
Original author: @wangzhishenghw

---
### What this PR does / why we need it?
This PR adds a notice and a reference link to Chapter 5 (Online Service
Deployment) in the GLM-5 tutorial. This helps users find complete
startup commands and parameter descriptions, and reminds them to
configure `max-model-len` and `max-num-seqs` according to their actual
usage scenarios.
### Does this PR introduce _any_ user-facing change?
No, this is a documentation-only update.
### How was this patch tested?
Documentation changes only, verified markdown rendering.

- vLLM version: v0.23.0
- vLLM main:
vllm-project/vllm@ee0da84

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
xiayingqing pushed a commit to xiayingqing/vllm-ascend that referenced this pull request Aug 3, 2026
…2958)

### What this PR does / why we need it?
This PR adds a notice and a reference link to Chapter 5 (Online Service
Deployment) in the GLM-5 tutorial. This helps users find complete
startup commands and parameter descriptions, and reminds them to
configure `max-model-len` and `max-num-seqs` according to their actual
usage scenarios.
### Does this PR introduce _any_ user-facing change?
No, this is a documentation-only update.
### How was this patch tested?
Documentation changes only, verified markdown rendering.

- vLLM version: v0.26.0
- vLLM main:
vllm-project/vllm@d02df74

---------

Signed-off-by: wangzhishenghw <wangzhisheng6@h-partners.com>
Wyz-134 pushed a commit to Wyz-134/vllm-ascend that referenced this pull request Aug 5, 2026
* releases/v0.23.0: (104 commits)
  [Doc][BugFix] Update proxy script name in DeepSeek-V3.2 tutorial (vllm-project#13537)
  [Doc] Fix link errors and update documentation structure (vllm-project#13483)
  [BugFix][releases/v0.23.0] fix fiaV2 contiguous err in GQA (vllm-project#13458)
  [v0.23.0][BugFix] Isolate layerwise GVA keys by parallel rank (vllm-project#13513)
  [Doc][Feature] Add model support of Ascend 950 (vllm-project#13525)
  [Doc] fix DeepSeek V4 Flash&Pro model tutorial docs link error (vllm-project#13497)
  [Cherry-pick][releases/v0.23.0][Doc][Misc] Add limitation for reduce sample (from vllm-project#13468) (vllm-project#13469)
  [BugFix][v0.23.0][KV Pool] Include MTP KV in layerwise AscendStore transfer (vllm-project#13454)
  [Doc][Misc] Standardize TorchNPU capitalization and update Ascend 950 product terminology (vllm-project#13089)
  [v0.23.0][Doc] Translated Doc files 2026-08-04 (vllm-project#13437)
  [Misc][v0.23.0] Fix translation extraction for tables nested in tabs (vllm-project#13413)
  [Doc] Fix translation and formatting in documentation (vllm-project#13390)
  [releases/v0.23.0][Doc][Misc] Backport Kimi-K2-Thinking tuning docs to v0.23.0 (vllm-project#13361)
  [Doc] Deployment key parameter supplement- vllm-project#13297 (vllm-project#13299)
  [v0.23.0][Doc] Translated Doc files 2026-07-31 (vllm-project#13283)
  [Doc][Misc] Update max-num-seqs configurations in GLM5 tutorial (vllm-project#13203)
  [Cherry-pick][releases/v0.23.0][Doc][Misc] Add deployment reference notice for GLM-5 (from vllm-project#12958) (vllm-project#12960)
  [BugFix][v0.23.0][KV Pool] Guard batch_get_key_info before memcache backend init (vllm-project#13307)
  [DOC]Modify the scope of scenarios supported by CP (vllm-project#13303)
  Revert "[cherry-pick][v0.23.0][Performance] remove D2H sync in QLIMetadata builder for DSA_CP" (vllm-project#13289)
  ...
HMCCMH pushed a commit to hotTea123/vllm-ascend that referenced this pull request Aug 12, 2026
…2958)

### What this PR does / why we need it?
This PR adds a notice and a reference link to Chapter 5 (Online Service
Deployment) in the GLM-5 tutorial. This helps users find complete
startup commands and parameter descriptions, and reminds them to
configure `max-model-len` and `max-num-seqs` according to their actual
usage scenarios.
### Does this PR introduce _any_ user-facing change?
No, this is a documentation-only update.
### How was this patch tested?
Documentation changes only, verified markdown rendering.

- vLLM version: v0.26.0
- vLLM main:
vllm-project/vllm@d02df74

---------

Signed-off-by: wangzhishenghw <wangzhisheng6@h-partners.com>
MmMmaru pushed a commit to jiaqi-lee/vllm-ascend that referenced this pull request Aug 19, 2026
…2958)

### What this PR does / why we need it?
This PR adds a notice and a reference link to Chapter 5 (Online Service
Deployment) in the GLM-5 tutorial. This helps users find complete
startup commands and parameter descriptions, and reminds them to
configure `max-model-len` and `max-num-seqs` according to their actual
usage scenarios.
### Does this PR introduce _any_ user-facing change?
No, this is a documentation-only update.
### How was this patch tested?
Documentation changes only, verified markdown rendering.

- vLLM version: v0.26.0
- vLLM main:
vllm-project/vllm@d02df74

---------

Signed-off-by: wangzhishenghw <wangzhisheng6@h-partners.com>
shiqiangA pushed a commit to shiqiangA/vllm-ascend that referenced this pull request Aug 20, 2026
…2958)

### What this PR does / why we need it?
This PR adds a notice and a reference link to Chapter 5 (Online Service
Deployment) in the GLM-5 tutorial. This helps users find complete
startup commands and parameter descriptions, and reminds them to
configure `max-model-len` and `max-num-seqs` according to their actual
usage scenarios.
### Does this PR introduce _any_ user-facing change?
No, this is a documentation-only update.
### How was this patch tested?
Documentation changes only, verified markdown rendering.

- vLLM version: v0.26.0
- vLLM main:
vllm-project/vllm@d02df74

---------

Signed-off-by: wangzhishenghw <wangzhisheng6@h-partners.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants