[Doc][Misc] Add deployment reference notice for GLM-5 - #12958
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request updates the GLM5 tutorial documentation to provide clearer guidance on deployment parameters and references to the relevant configuration chapter, improving the user experience for those setting up the model. Highlights
New Features🧠 You can now enable Memory (public preview) to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request updates the GLM-5 tutorial documentation by adding a notice and reference link to Chapter 5 (Online Service Deployment) to guide users on configuring max-model-len and max-num-seqs. The reviewer noted that the PR title and description do not adhere to the repository's Pull Request Summary Style Guide and provided a compliant template to use.
| |High Throughput (A3)|1P1D deployment|32|P:8 D:4|P:4 D:8|P:64 D:128|P:4096 D:32|P:133120 D:150000|3| | ||
| |Low Latency (A3)|1P1D deployment|32|4|8|P:64 D:128|P:4096 D:32|P:133120 D:150000|3| | ||
|
|
||
| > For complete startup commands and parameter descriptions, please refer to the deployment examples in [Chapter 5](#5-online-service-deployment). |
There was a problem hiding this comment.
The current Pull Request title and description do not follow the repository's Pull Request Summary Style Guide. Please update them to match the required format.\n\nSuggested PR Title:\n\nmarkdown\n[Doc][Misc] Add deployment reference notice for GLM-5\n\n\nSuggested PR Summary:\n\nmarkdown\n### What this PR does / why we need it?\n\nThis PR adds a notice and a reference link to Chapter 5 (Online Service Deployment) in the GLM-5 tutorial. This helps users find complete startup commands and parameter descriptions, and reminds them to configure `max-model-len` and `max-num-seqs` according to their actual usage scenarios.\n\n### Does this PR introduce _any_ user-facing change?\n\nNo, this is a documentation-only update.\n\n### How was this patch tested?\n\nDocumentation changes only, verified markdown rendering.\n
References
- The Pull Request title and summary must follow the specified format and be output in markdown code blocks. (link)
|
👋 Hi! Thank you for contributing to the vLLM Ascend project. The following points will speed up your PR merge:
If CI fails, you can run linting and testing checks locally according Contributing and Testing. |
|
/cherry-pick releases/v0.24.0rc |
|
/cherry-pick releases/v0.23.0 |
1e9f22e to
959b1c9
Compare
|
/cherry-pick releases/v0.23.0 |
|
/cherry-pick releases/v0.24.0rc |
Cherry-pick of PR vllm-project#12958 by @wangzhishenghw
Cherry-pick of PR vllm-project#12958 by @wangzhishenghw
|
/cherry-pick releases/v0.23.0 |
|
/cherry-pick releases/v0.24.0rc |
Cherry-pick of PR vllm-project#12958 by @wangzhishenghw
… notice for GLM-5 (from #12958) (#12961) Cherry-pick of PR #12958 onto `releases/v0.24.0rc`. Original PR: #12958 Original author: @wangzhishenghw --- ### What this PR does / why we need it? This PR adds a notice and a reference link to Chapter 5 (Online Service Deployment) in the GLM-5 tutorial. This helps users find complete startup commands and parameter descriptions, and reminds them to configure `max-model-len` and `max-num-seqs` according to their actual usage scenarios. ### Does this PR introduce _any_ user-facing change? No, this is a documentation-only update. ### How was this patch tested? Documentation changes only, verified markdown rendering. - vLLM version: v0.24.0 - vLLM main: vllm-project/vllm@85c09e9 Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
…otice for GLM-5 (from #12958) (#12960) Cherry-pick of PR #12958 onto `releases/v0.23.0`. Original PR: #12958 Original author: @wangzhishenghw --- ### What this PR does / why we need it? This PR adds a notice and a reference link to Chapter 5 (Online Service Deployment) in the GLM-5 tutorial. This helps users find complete startup commands and parameter descriptions, and reminds them to configure `max-model-len` and `max-num-seqs` according to their actual usage scenarios. ### Does this PR introduce _any_ user-facing change? No, this is a documentation-only update. ### How was this patch tested? Documentation changes only, verified markdown rendering. - vLLM version: v0.23.0 - vLLM main: vllm-project/vllm@ee0da84 Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
…2958) ### What this PR does / why we need it? This PR adds a notice and a reference link to Chapter 5 (Online Service Deployment) in the GLM-5 tutorial. This helps users find complete startup commands and parameter descriptions, and reminds them to configure `max-model-len` and `max-num-seqs` according to their actual usage scenarios. ### Does this PR introduce _any_ user-facing change? No, this is a documentation-only update. ### How was this patch tested? Documentation changes only, verified markdown rendering. - vLLM version: v0.26.0 - vLLM main: vllm-project/vllm@d02df74 --------- Signed-off-by: wangzhishenghw <wangzhisheng6@h-partners.com>
* releases/v0.23.0: (104 commits) [Doc][BugFix] Update proxy script name in DeepSeek-V3.2 tutorial (vllm-project#13537) [Doc] Fix link errors and update documentation structure (vllm-project#13483) [BugFix][releases/v0.23.0] fix fiaV2 contiguous err in GQA (vllm-project#13458) [v0.23.0][BugFix] Isolate layerwise GVA keys by parallel rank (vllm-project#13513) [Doc][Feature] Add model support of Ascend 950 (vllm-project#13525) [Doc] fix DeepSeek V4 Flash&Pro model tutorial docs link error (vllm-project#13497) [Cherry-pick][releases/v0.23.0][Doc][Misc] Add limitation for reduce sample (from vllm-project#13468) (vllm-project#13469) [BugFix][v0.23.0][KV Pool] Include MTP KV in layerwise AscendStore transfer (vllm-project#13454) [Doc][Misc] Standardize TorchNPU capitalization and update Ascend 950 product terminology (vllm-project#13089) [v0.23.0][Doc] Translated Doc files 2026-08-04 (vllm-project#13437) [Misc][v0.23.0] Fix translation extraction for tables nested in tabs (vllm-project#13413) [Doc] Fix translation and formatting in documentation (vllm-project#13390) [releases/v0.23.0][Doc][Misc] Backport Kimi-K2-Thinking tuning docs to v0.23.0 (vllm-project#13361) [Doc] Deployment key parameter supplement- vllm-project#13297 (vllm-project#13299) [v0.23.0][Doc] Translated Doc files 2026-07-31 (vllm-project#13283) [Doc][Misc] Update max-num-seqs configurations in GLM5 tutorial (vllm-project#13203) [Cherry-pick][releases/v0.23.0][Doc][Misc] Add deployment reference notice for GLM-5 (from vllm-project#12958) (vllm-project#12960) [BugFix][v0.23.0][KV Pool] Guard batch_get_key_info before memcache backend init (vllm-project#13307) [DOC]Modify the scope of scenarios supported by CP (vllm-project#13303) Revert "[cherry-pick][v0.23.0][Performance] remove D2H sync in QLIMetadata builder for DSA_CP" (vllm-project#13289) ...
…2958) ### What this PR does / why we need it? This PR adds a notice and a reference link to Chapter 5 (Online Service Deployment) in the GLM-5 tutorial. This helps users find complete startup commands and parameter descriptions, and reminds them to configure `max-model-len` and `max-num-seqs` according to their actual usage scenarios. ### Does this PR introduce _any_ user-facing change? No, this is a documentation-only update. ### How was this patch tested? Documentation changes only, verified markdown rendering. - vLLM version: v0.26.0 - vLLM main: vllm-project/vllm@d02df74 --------- Signed-off-by: wangzhishenghw <wangzhisheng6@h-partners.com>
…2958) ### What this PR does / why we need it? This PR adds a notice and a reference link to Chapter 5 (Online Service Deployment) in the GLM-5 tutorial. This helps users find complete startup commands and parameter descriptions, and reminds them to configure `max-model-len` and `max-num-seqs` according to their actual usage scenarios. ### Does this PR introduce _any_ user-facing change? No, this is a documentation-only update. ### How was this patch tested? Documentation changes only, verified markdown rendering. - vLLM version: v0.26.0 - vLLM main: vllm-project/vllm@d02df74 --------- Signed-off-by: wangzhishenghw <wangzhisheng6@h-partners.com>
…2958) ### What this PR does / why we need it? This PR adds a notice and a reference link to Chapter 5 (Online Service Deployment) in the GLM-5 tutorial. This helps users find complete startup commands and parameter descriptions, and reminds them to configure `max-model-len` and `max-num-seqs` according to their actual usage scenarios. ### Does this PR introduce _any_ user-facing change? No, this is a documentation-only update. ### How was this patch tested? Documentation changes only, verified markdown rendering. - vLLM version: v0.26.0 - vLLM main: vllm-project/vllm@d02df74 --------- Signed-off-by: wangzhishenghw <wangzhisheng6@h-partners.com>
What this PR does / why we need it?
This PR adds a notice and a reference link to Chapter 5 (Online Service Deployment) in the GLM-5 tutorial. This helps users find complete startup commands and parameter descriptions, and reminds them to configure
max-model-lenandmax-num-seqsaccording to their actual usage scenarios.Does this PR introduce any user-facing change?
No, this is a documentation-only update.
How was this patch tested?
Documentation changes only, verified markdown rendering.