-
Notifications
You must be signed in to change notification settings - Fork 1.2k
[CI] Run e2e after pre check pass #1132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
This file was deleted.
This file was deleted.
This file was deleted.
| Original file line number | Diff line number | Diff line change | ||||||
|---|---|---|---|---|---|---|---|---|
|
|
@@ -15,7 +15,7 @@ | |||||||
| # This file is a part of the vllm-ascend project. | ||||||||
| # | ||||||||
|
|
||||||||
| name: 'e2e test' | ||||||||
| name: 'test' | ||||||||
|
|
||||||||
| on: | ||||||||
| schedule: | ||||||||
|
|
@@ -31,6 +31,9 @@ on: | |||||||
| - '!docs/**' | ||||||||
| - 'pytest.ini' | ||||||||
| - '!benchmarks/**' | ||||||||
| - 'tools/mypy.sh' | ||||||||
| - 'mypy.ini' | ||||||||
|
|
||||||||
| # Bash shells do not use ~/.profile or ~/.bashrc so these shells need to be explicitly | ||||||||
| # declared as "shell: bash -el {0}" on steps that need to be properly activated. | ||||||||
| # It's used to activate ascend-toolkit environment variables. | ||||||||
|
|
@@ -39,7 +42,65 @@ defaults: | |||||||
| shell: bash -el {0} | ||||||||
|
|
||||||||
| jobs: | ||||||||
| test: | ||||||||
| lint: | ||||||||
| runs-on: ubuntu-latest | ||||||||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||||
| strategy: | ||||||||
| matrix: | ||||||||
| python-version: ["3.10"] | ||||||||
| steps: | ||||||||
| - uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2 | ||||||||
| - name: Set up Python ${{ matrix.python-version }} | ||||||||
| uses: actions/setup-python@a26af69be951a213d495a4c3e4e4022e16d87065 # v5.6.0 | ||||||||
| with: | ||||||||
| python-version: ${{ matrix.python-version }} | ||||||||
| - name: Install dependencies | ||||||||
| run: | | ||||||||
| python -m pip install --upgrade pip | ||||||||
| pip install -r requirements-lint.txt | ||||||||
| - name: Run codespell check | ||||||||
| run: | | ||||||||
| CODESPELL_EXCLUDES=('--skip' 'tests/prompts/**,./benchmarks/sonnet.txt,*tests/lora/data/**,build/**,./vllm_ascend.egg-info/**') | ||||||||
| CODESPELL_IGNORE_WORDS=('-L' 'CANN,cann,NNAL,nnal,ASCEND,ascend,EnQue,CopyIn') | ||||||||
|
|
||||||||
| codespell --toml pyproject.toml "${CODESPELL_EXCLUDES[@]}" "${CODESPELL_IGNORE_WORDS[@]}" | ||||||||
| - name: Analysing the code with ruff | ||||||||
| run: | | ||||||||
| echo "::add-matcher::.github/workflows/matchers/ruff.json" | ||||||||
| ruff check --output-format github . | ||||||||
| - name: Run isort | ||||||||
| run: | | ||||||||
| isort . --check-only | ||||||||
| - name: Running yapf | ||||||||
| run: | | ||||||||
| python -m pip install --upgrade pip | ||||||||
| pip install toml | ||||||||
| pip install yapf==0.32.0 | ||||||||
| yapf --diff --recursive . | ||||||||
|
|
||||||||
| - name: Install dependencies | ||||||||
| run: | | ||||||||
| pip install -r requirements-dev.txt --extra-index-url https://download.pytorch.org/whl/cpu | ||||||||
|
|
||||||||
| - name: Checkout vllm-project/vllm repo | ||||||||
| uses: actions/checkout@v4 | ||||||||
| with: | ||||||||
| repository: vllm-project/vllm | ||||||||
| path: vllm-empty | ||||||||
|
|
||||||||
| - name: Install vllm-project/vllm from source | ||||||||
| working-directory: vllm-empty | ||||||||
| run: | | ||||||||
| pip install -r requirements/build.txt --extra-index-url https://download.pytorch.org/whl/cpu | ||||||||
| VLLM_TARGET_DEVICE=empty pip install . | ||||||||
|
|
||||||||
| - name: Mypy Check | ||||||||
| run: | | ||||||||
| echo "::add-matcher::.github/workflows/matchers/mypy.json" | ||||||||
| tools/mypy.sh 1 ${{ matrix.python-version }} | ||||||||
|
|
||||||||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Any reason why only actionlint left?
Collaborator
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. let's merge others in the next PR |
||||||||
| e2e: | ||||||||
| needs: [lint] | ||||||||
| if: ${{ needs.lint.result == 'success' }} | ||||||||
| strategy: | ||||||||
| max-parallel: 2 | ||||||||
| matrix: | ||||||||
|
|
||||||||
This file was deleted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we squash yapf, codespell, ruff into one?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think leave mypy test to one is fine as well.