[CI] Run e2e after pre check pass#1132
Merged
wangxiyuan merged 1 commit intovllm-project:mainfrom Jun 10, 2025
Merged
Conversation
wangxiyuan
force-pushed
the
e2e_update
branch
2 times, most recently
from
00909c7 to
6571a10
Compare
wangxiyuan
force-pushed
the
e2e_update
branch
2 times, most recently
from
d3d7a71 to
aec9b62
Compare
Yikun
reviewed
Jun 9, 2025
| @@ -39,7 +42,107 @@ defaults: | |||
| shell: bash -el {0} | |||
|
|
|||
| jobs: | |||
Member
There was a problem hiding this comment.
Could we squash yapf, codespell, ruff into one?
Collaborator
Author
There was a problem hiding this comment.
I think leave mypy test to one is fine as well.
Collaborator
Author
|
@Yikun please take a look again. Merged the 4 lint check into one. https://github.com/vllm-project/vllm-ascend/actions/runs/15552048318?pr=1132 |
Yikun
approved these changes
Jun 10, 2025
Member
Yikun
left a comment
Yikun
left a comment
There was a problem hiding this comment.
Looks good except comments inline.
BTW, I think we can do some thing pre-commit in future.
https://github.com/vllm-project/vllm/blob/main/.github/workflows/pre-commit.yml
| # | ||
|
|
||
| name: 'e2e test' | ||
| name: 'Basic Test' |
Member
There was a problem hiding this comment.
Suggested change
| name: 'Basic Test' | |
| name: 'test' |
|
|
||
| jobs: | ||
| lint: | ||
| runs-on: ubuntu-latest |
Member
There was a problem hiding this comment.
Suggested change
| runs-on: ubuntu-latest | |
| runs-on: ubuntu-latest | |
| name: lint |
| run: | | ||
| echo "::add-matcher::.github/workflows/matchers/mypy.json" | ||
| tools/mypy.sh 1 ${{ matrix.python-version }} | ||
|
|
Member
There was a problem hiding this comment.
Any reason why only actionlint left?
Collaborator
Author
There was a problem hiding this comment.
let's merge others in the next PR
Signed-off-by: wangxiyuan <wangxiyuan1007@gmail.com>
momo609
pushed a commit
to momo609/vllm-ascend
that referenced
this pull request
Jun 17, 2025
Make sure the lint test passed before start the e2e test to save compute resource. Updated the patch doc to make sure the CI works as expect. Signed-off-by: wangxiyuan <wangxiyuan1007@gmail.com>
momo609
pushed a commit
to momo609/vllm-ascend
that referenced
this pull request
Jun 17, 2025
Make sure the lint test passed before start the e2e test to save compute resource. Updated the patch doc to make sure the CI works as expect. Signed-off-by: wangxiyuan <wangxiyuan1007@gmail.com> Signed-off-by: wangxiaoxin (A) <wangxiaoxin7@huawei.com>
momo609
pushed a commit
to momo609/vllm-ascend
that referenced
this pull request
Jun 17, 2025
Make sure the lint test passed before start the e2e test to save compute resource. Updated the patch doc to make sure the CI works as expect. Signed-off-by: wangxiyuan <wangxiyuan1007@gmail.com> Signed-off-by: wangxiaoxin (A) <wangxiaoxin7@huawei.com>
chopper0126
pushed a commit
to chopper0126/vllm-ascend
that referenced
this pull request
Oct 16, 2025
Make sure the lint test passed before start the e2e test to save compute resource. Updated the patch doc to make sure the CI works as expect. Signed-off-by: wangxiyuan <wangxiyuan1007@gmail.com>
Angazenn
pushed a commit
to Angazenn/vllm-ascend
that referenced
this pull request
Oct 21, 2025
Make sure the lint test passed before start the e2e test to save compute resource. Updated the patch doc to make sure the CI works as expect. Signed-off-by: wangxiyuan <wangxiyuan1007@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make sure the lint test passed before start the e2e test to save compute resource.
Updated the patch doc to make sure the CI works as expect.