Skip to content

[Feat] allow annotation on router pod #743

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Nov 5, 2025
Merged

[Feat] allow annotation on router pod #743

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
d144d7d
feature - allow annotation on router pod
NargiT Oct 30, 2025
b34eca1
Add property to values.yaml
NargiT Oct 30, 2025
82f25b2
Update helm/templates/deployment-router.yaml
NargiT Oct 30, 2025
2fe6b99
Merge branch 'main' into add/router-annotation
zerofishnoodles Oct 31, 2025
5087019
Add routerSpec.podAnnotations to helm README values
NargiT Nov 4, 2025
da20d68
Merge branch 'add/router-annotation' of https://github.com/NargiT/pro…
NargiT Nov 4, 2025
f656f81
rollback formating
NargiT Nov 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions helm/templates/_helpers.tpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -180,6 +180,7 @@ limits:
{{- end }}
{{- end }}


{{/*
Define labels for cache server and its service
*/}}
Expand Down
4 changes: 4 additions & 0 deletions helm/templates/deployment-router.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,10 @@ spec:
metadata:
labels:
{{- include "chart.routerLabels" . | nindent 8 }}
{{- with .Values.routerSpec.podAnnotations }}
annotations:
{{- toYaml . | nindent 8 }}
{{- end }}
spec:
serviceAccountName: {{ .Release.Name }}-router-service-account
{{- if .Values.routerSpec.priorityClassName }}
Expand Down
6 changes: 6 additions & 0 deletions helm/values.schema.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -537,6 +537,12 @@
"type": "string"
}
}
},
"podAnnotations": {
"type": "object",
"additionalProperties": {
"type": "string"
}
}
}
}
Expand Down
3 changes: 3 additions & 0 deletions helm/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -381,6 +381,9 @@ routerSpec:
environment: "router"
release: "router"

# -- Customized pod annotations for the router pods
podAnnotations: {}
Copy link
Collaborator

@zerofishnoodles zerofishnoodles Oct 31, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does service need annotation under some conditions too? If there is a possibility, would it be better to make this annotation more general to service too?

Copy link
Contributor Author

@NargiT NargiT Nov 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are only 2 annotations that are Service specific in istio so far and one that is global to any resource.

I can add another property serviceAnnotations but I don't think they should be shared for all annoation.

What do you want me to do ?

Copy link
Collaborator

@zerofishnoodles zerofishnoodles Nov 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see. If there is no need right now for serviceAnnotation, then it is okay to leave it like this. Could you add this new field to the helm readme values section?

Copy link
Contributor Author

@NargiT NargiT Nov 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Voilà


ingress:
# -- Enable ingress controller resource
enabled: false
Expand Down