Skip to content

[ROCm] Added all current MI3XX agents #293

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
khluu merged 3 commits into from
Feb 25, 2026
+26 −9
Merged

[ROCm] Added all current MI3XX agents #293

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
43fb71e
[ROCm] Added all current MI3XX agents
AndreasKaratzas Feb 24, 2026
f05e86c
Fix NoneType error in source_file_dependencies when step omits the field
AndreasKaratzas Feb 25, 2026
5d5bf44
Merge remote-tracking branch 'origin/main' into akaratza_adding_mi3xx…
AndreasKaratzas Feb 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 14 additions & 8 deletions buildkite/pipeline_generator/buildkite_step.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -306,15 +306,21 @@ def _create_amd_mirror_step(step: Step, original_commands: List[str], amd: Dict[
device_type = amd_device.replace("amd_", "") if amd_device.startswith("amd_") else amd_device
amd_label = f"AMD: {step.label} ({device_type})"

# Get AMD queue name from device name
amd_queue = None
if amd_device == DeviceType.AMD_MI325_1:
amd_queue = AgentQueue.AMD_MI325_1
elif amd_device == DeviceType.AMD_MI325_8:
amd_queue = AgentQueue.AMD_MI325_8

# Map device type to agent queue
amd_queue_map = {
DeviceType.AMD_MI325_1: AgentQueue.AMD_MI325_1,
DeviceType.AMD_MI325_2: AgentQueue.AMD_MI325_2,
DeviceType.AMD_MI325_4: AgentQueue.AMD_MI325_4,
DeviceType.AMD_MI325_8: AgentQueue.AMD_MI325_8,
DeviceType.AMD_MI355_1: AgentQueue.AMD_MI355_1,
DeviceType.AMD_MI355_2: AgentQueue.AMD_MI355_2,
DeviceType.AMD_MI355_4: AgentQueue.AMD_MI355_4,
DeviceType.AMD_MI355_8: AgentQueue.AMD_MI355_8,
}

amd_queue = amd_queue_map.get(amd_device)
if not amd_queue:
raise ValueError(f"Invalid device: {amd_device}")
raise ValueError(f"Invalid AMD device: {amd_device}. Valid devices: {list(amd_queue_map.keys())}")

amd_retry = {
"automatic": [
Expand Down
13 changes: 12 additions & 1 deletion buildkite/pipeline_generator/constants.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,13 @@ class DeviceType(str, Enum):
ASCEND = "ascend_npu"
AMD_CPU = "amd_cpu"
AMD_MI325_1 = "mi325_1"
AMD_MI325_2 = "mi325_2"
AMD_MI325_4 = "mi325_4"
AMD_MI325_8 = "mi325_8"

AMD_MI355_1 = "mi355_1"
AMD_MI355_2 = "mi355_2"
AMD_MI355_4 = "mi355_4"
AMD_MI355_8 = "mi355_8"


class AgentQueue(str, Enum):
Expand All @@ -41,4 +46,10 @@ class AgentQueue(str, Enum):
ASCEND = "ascend"
AMD_CPU = "amd-cpu"
AMD_MI325_1 = "amd_mi325_1"
AMD_MI325_2 = "amd_mi325_2"
AMD_MI325_4 = "amd_mi325_4"
AMD_MI325_8 = "amd_mi325_8"
AMD_MI355_1 = "amd_mi355_1"
AMD_MI355_2 = "amd_mi355_2"
AMD_MI355_4 = "amd_mi355_4"
AMD_MI355_8 = "amd_mi355_8"