[ROCm] Added all current MI3XX agents#293
Merged
khluu merged 3 commits intovllm-project:mainfrom Feb 25, 2026
Merged
Conversation
Signed-off-by: Andreas Karatzas <akaratza@amd.com>
AndreasKaratzas
force-pushed
the
akaratza_adding_mi3xx_agents
branch
from
8e68591 to
43fb71e
Compare
Signed-off-by: Andreas Karatzas <akaratza@amd.com>
Collaborator
Author
|
The last commit fixes AttributeError: 'NoneType' object has no attribute 'append' in read_steps_from_job_dir. When a step doesn't define source_file_dependencies, Pydantic sets it to None. getattr returns None (not []) since the attribute exists, causing the crash on .append() |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The pipeline generator's
constants.pywas missing several AMD device types that are already referenced in the Jinja2 templates (test-template-ci.j2). This PR closes that gap and adds forward-looking support for MI355.