Skip to content

vLLM Easier cudagraph integration #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tlrmchlsmth merged 2 commits into from
Aug 5, 2025
Merged

vLLM Easier cudagraph integration #3

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
75cb7a7
use -1 for invalid tiles
LucasWilkinson Aug 4, 2025
3edc935
easier num_splits
LucasWilkinson Aug 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion csrc/kernels/get_mla_metadata.cu
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ get_mla_metadata_kernel(__grid_constant__ const Mla_metadata_params params) {
num_splits_shared[0] = 0;
for (int i = 0; i < num_sm_parts; ++i) {
int tile_scheduler_metadata0[4], tile_scheduler_metadata1;
tile_scheduler_metadata0[0] = now_idx;
tile_scheduler_metadata0[0] = (now_idx >= batch_size ? -1 : now_idx);
tile_scheduler_metadata0[1] = now_block * block_size_n;
tile_scheduler_metadata1 = now_n_split_idx;
int remain_payload = payload;
Expand Down
2 changes: 1 addition & 1 deletion csrc/kernels/mla_combine.cu
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ flash_fwd_mla_combine_kernel(__grid_constant__ const Flash_fwd_mla_params params
const int end_split_idx = __ldg(params.num_splits_ptr + batch_idx + 1);
const int my_num_splits = end_split_idx - start_split_idx;
FLASH_DEVICE_ASSERT(my_num_splits <= MAX_SPLITS);
if (my_num_splits == 1) {
if (my_num_splits <= 1) {
return;
}

Expand Down
2 changes: 1 addition & 1 deletion csrc/kernels/splitkv_mla.cu
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1022,7 +1022,7 @@ flash_fwd_splitkv_mla_kernel(__grid_constant__ const Flash_fwd_mla_params params
int begin_seqlen = tile_scheduler_metadata.y;
int end_idx = tile_scheduler_metadata.z;
int end_seqlen = tile_scheduler_metadata.w;
if (begin_idx >= params.b) return;
if (begin_idx >= params.b || begin_idx < 0) return;
int begin_n_split_idx = __ldg(tile_scheduler_metadata_ptr + 4);

// Copy the first Q
Expand Down