Merged
Conversation
Signed-off-by: Lucas Wilkinson <lwilkins@redhat.com>
Signed-off-by: Lucas Wilkinson <lwilkins@redhat.com>
4 tasks
tlrmchlsmth
approved these changes
Aug 5, 2025
MatthewBonanni
added a commit
to MatthewBonanni/FlashMLA
that referenced
this pull request
Aug 12, 2025
Signed-off-by: Matthew Bonanni <mbonanni001@gmail.com>
LucasWilkinson
pushed a commit
that referenced
this pull request
Aug 18, 2025
* Add files from deepseek-ai#54 Signed-off-by: Matthew Bonanni <mbonanni001@gmail.com> * FP8 now extends base implementation Signed-off-by: Matthew Bonanni <mbonanni001@gmail.com> * Fix typo Signed-off-by: Matthew Bonanni <mbonanni001@gmail.com> * Update tests Signed-off-by: Matthew Bonanni <mbonanni001@gmail.com> * Add to build Signed-off-by: Matthew Bonanni <mbonanni001@gmail.com> * Fix installation Signed-off-by: Matthew Bonanni <mbonanni001@gmail.com> * Fix FLASH_MLA_DISABLE_FP8 flag Signed-off-by: Matthew Bonanni <mbonanni001@gmail.com> * Fix param matchup Signed-off-by: Matthew Bonanni <mbonanni001@gmail.com> * typo Signed-off-by: Matthew Bonanni <mbonanni001@gmail.com> * Fix out dtype Signed-off-by: Matthew Bonanni <mbonanni001@gmail.com> * Fix IMA Signed-off-by: Matthew Bonanni <mbonanni001@gmail.com> * Extension name should be _flashmla_C Signed-off-by: Matthew Bonanni <mbonanni001@gmail.com> * Clean up Signed-off-by: Matthew Bonanni <mbonanni001@gmail.com> * Tighten FP8 error tolerance Signed-off-by: Matthew Bonanni <mbonanni001@gmail.com> * Add attribution to copied files Signed-off-by: Matthew Bonanni <mbonanni001@gmail.com> * Remove breakpoint Signed-off-by: Matthew Bonanni <mbonanni001@gmail.com> * Port cudagraph fix from #3 Signed-off-by: Matthew Bonanni <mbonanni001@gmail.com> --------- Signed-off-by: Matthew Bonanni <mbonanni001@gmail.com>
Closed
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes it easier to get a correct FlashMLA full cudagraph integration in vLLM where padding for cudagraph's happens after attention metadata data building (i.e.
get_mla_metadata)The changes
and
allows
get_mla_metadatato be called with a smaller batch size than the graph was captured with since it now uses-1to mark no-work tiles instead ofparams.bThe change
makes it easier to pad out
num_splits(cumulative) since we can just do:which pads with 0 split elements instead of have to pad with 1 split elements which is more complicated: