Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open Project error handling #1740

Merged
merged 2 commits into from
Mar 9, 2024
Merged

Open Project error handling #1740

merged 2 commits into from
Mar 9, 2024

Conversation

vkbo
Copy link
Owner

@vkbo vkbo commented Mar 9, 2024

Summary:

This PR:

  • Changes the error on missing (deleted) projects reported by the storage class to NOT_FOUND instead of UNKNOWN, which produces a more accurate error message for the user.
  • Adds a check after the Welcome dialog has returned and an open project request has been processed. The check will pop open the Welcome dialog again if the previous process did not result in an open project. This will not trigger if there already was a project open before the Welcome dialog was opened. Only when the process results in a blank UI.

Related Issue(s):

Closes #1737

Reviewer's Checklist:

  • The header of all files contain a reference to the repository license
  • The overall test coverage is increased or remains the same as before
  • All tests are passing
  • All flake8 checks are passing and the style guide is followed
  • Documentation (as docstrings) is complete and understandable
  • Only files that have been actively changed are committed

@vkbo vkbo added this to the Release 2.3 milestone Mar 9, 2024
@vkbo vkbo merged commit 8d614c2 into main Mar 9, 2024
9 checks passed
@vkbo vkbo deleted the proect_error_handling branch March 9, 2024 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong error when opening nonexistent project
1 participant