Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong error when opening nonexistent project #1737

Closed
HeyMyian opened this issue Mar 9, 2024 · 2 comments · Fixed by #1740
Closed

Wrong error when opening nonexistent project #1737

HeyMyian opened this issue Mar 9, 2024 · 2 comments · Fixed by #1740
Labels
usability Issue: Could do with some improvement
Milestone

Comments

@HeyMyian
Copy link
Contributor

HeyMyian commented Mar 9, 2024

I created and deleted a test project. When trying to open this test project from the list, the error says:

Not a known project file format.

I think the correct error should be one of these strings?

Project file not found.
The project path is not reachable.

It would also be great to return to the Welcome screen when the opening of a project fails. Chances are I want to try again.

@HeyMyian HeyMyian added the bug Issue: Something isn't working label Mar 9, 2024
@vkbo
Copy link
Owner

vkbo commented Mar 9, 2024

The error type is correct. The text is just misleading. It's a generic error caused by the folder missing the project file because you deleted the parent folder. The result is that novelWriter doesn't recognise the project format (i.e. the folder structure). The error was actually added for the case of single file projects, which hasn't been released yet, but I'll swap it with a more sensible error type.

As for the Welcome dialog, this happens after the Welcome dialog has done its work and returned the selected path to the main GUI, so it is already closed. I'll look into if it can be reopened. It is of course available from the Project menu still.

@vkbo vkbo added usability Issue: Could do with some improvement and removed bug Issue: Something isn't working labels Mar 9, 2024
@vkbo vkbo added this to the Release 2.3 milestone Mar 9, 2024
@vkbo vkbo mentioned this issue Mar 9, 2024
6 tasks
@vkbo
Copy link
Owner

vkbo commented Mar 9, 2024

#1740 adds a check after the path returned from the Welcome dialog has been processed by the main app. If the process does not result in an open project (assuming one was not already open), the Welcome dialog pops up again.

@vkbo vkbo closed this as completed in #1740 Mar 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
usability Issue: Could do with some improvement
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants