Skip to content

fix: externalize before caching #9077

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sheremet-va merged 2 commits into from
Nov 24, 2025
+6 −6
Merged

fix: externalize before caching #9077

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
445b1ce
fix: externalize before caching
sheremet-va Nov 21, 2025
d3ef427
chore: up version
sheremet-va Nov 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/vitest/src/node/cache/fsModuleCache.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ export class FileSystemModuleCache {
private rootCache: string
private metadataFilePath: string

private version = '1.0.0-beta.1'
private version = '1.0.0-beta.2'
private fsCacheRoots = new WeakMap<ResolvedConfig, string>()
private fsEnvironmentHashMap = new WeakMap<DevEnvironment, string>()
private fsCacheKeyGenerators = new Set<CacheKeyIdGenerator>()
Expand Down
10 changes: 5 additions & 5 deletions packages/vitest/src/node/environments/fetchModule.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,6 +66,11 @@ class ModuleFetcher {
return { cache: true }
}

const externalize = await this.resolver.shouldExternalize(moduleGraphModule.id!)
if (externalize) {
return { externalize, type: 'module' }
}

const cachePath = await this.getCachePath(
environment,
moduleGraphModule,
Expand Down Expand Up @@ -271,11 +276,6 @@ class ModuleFetcher {
moduleGraphModule: EnvironmentModuleNode,
options?: FetchFunctionOptions,
): Promise<FetchResult> {
const externalize = await this.resolver.shouldExternalize(moduleGraphModule.id!)
if (externalize) {
return { externalize, type: 'module' }
}

const moduleRunnerModule = await fetchModule(
environment,
url,
Expand Down
Loading