Skip to content

Conversation

@sheremet-va
Copy link
Member

@sheremet-va sheremet-va commented Nov 21, 2025

Description

I removed externalization from caching because it's faster to just do it once and reuse the memory cache than to read a file in #9076

But I forgot to move it before we create the cache key. Now vitest doesn't read the file content to generate the cache key

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. If the feature is substantial or introduces breaking changes without a discussion, PR might be closed.
  • Ideally, include a test that fails without this PR but passes with it.
  • Please, don't make changes to pnpm-lock.yaml unless you introduce a new test example.
  • Please check Allow edits by maintainers to make review process faster. Note that this option is not available for repositories that are owned by Github organizations.

Tests

  • Run the tests with pnpm test:ci.

Documentation

  • If you introduce new functionality, document it. You can run documentation with pnpm run docs command.

Changesets

  • Changes in changelog are generated from PR name. Please, make sure that it explains your changes in an understandable manner. Please, prefix changeset messages with feat:, fix:, perf:, docs:, or chore:.

@sheremet-va sheremet-va requested a review from hi-ogawa November 21, 2025 17:32
@sheremet-va sheremet-va merged commit e1b2e08 into vitest-dev:main Nov 24, 2025
14 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant