Skip to content

Replace slave with replica in vtctl commands and flags#467

Merged
deepthi merged 4 commits intoprodfrom
rename-slave-replica
Jul 16, 2020
Merged

Replace slave with replica in vtctl commands and flags#467
deepthi merged 4 commits intoprodfrom
rename-slave-replica

Conversation

@deepthi
Copy link
Copy Markdown
Collaborator

@deepthi deepthi commented Jul 8, 2020

  • Rename StopSlave -> StopReplication.
  • Rename StartSlave -> StartReplication.
  • Rename ChangeSlaveType -> ChangeTabletType.
  • Rename flag wait_slave_timeout to wait_replicas_timeout for all vtctl commands (ISM, PRS, ERS, ApplySchema, CopySchemaShard).

This is a companion PR to vitessio/vitess#6428

@deepthi deepthi force-pushed the rename-slave-replica branch from 921fb79 to 784812d Compare July 8, 2020 23:03
Signed-off-by: deepthi <deepthi@planetscale.com>
@deepthi deepthi force-pushed the rename-slave-replica branch from 784812d to 076508c Compare July 8, 2020 23:06
@lucperkins
Copy link
Copy Markdown
Collaborator

Nice 👍

deepthi added 2 commits July 12, 2020 21:02
Signed-off-by: deepthi <deepthi@planetscale.com>
Signed-off-by: deepthi <deepthi@planetscale.com>
@deepthi deepthi changed the title change references to wait_slave_timeout -> wait_replicas_timeout Replace slave with replica in vtctl commands and flags Jul 14, 2020
Signed-off-by: deepthi <deepthi@planetscale.com>
@deepthi deepthi marked this pull request as ready for review July 14, 2020 04:11
@deepthi deepthi requested review from ajm188, sougou and zmagg July 14, 2020 04:11
Copy link
Copy Markdown
Contributor

@shlomi-noach shlomi-noach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@deepthi deepthi merged commit dcbf1f5 into prod Jul 16, 2020
@shlomi-noach shlomi-noach deleted the rename-slave-replica branch July 16, 2020 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants