Replace slave with replica in vtctl commands and flags#6428
Merged
Conversation
…cument old flags. ensure test coverage for old and new flags Signed-off-by: deepthi <deepthi@planetscale.com>
4 tasks
Signed-off-by: deepthi <deepthi@planetscale.com>
…ication,StopReplication,ChangeTabletType} Signed-off-by: Andrew Mason <amason@slack-corp.com>
deepthi
commented
Jul 9, 2020
Signed-off-by: Andrew Mason <amason@slack-corp.com>
Signed-off-by: deepthi <deepthi@planetscale.com>
…e to old commands Signed-off-by: deepthi <deepthi@planetscale.com>
shlomi-noach
approved these changes
Jul 14, 2020
Signed-off-by: deepthi <deepthi@planetscale.com>
sougou
approved these changes
Jul 16, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
wait_slave_timeouttowait_replicas_timeoutfor reparenting commands (ISM, PRS, ERS).wait_slave_timeouttowait_replicas_timeoutfor schema commands (ApplySchema,CopySchemaShard).schema_change_slave_timeouttoschema_change_replicas_timeout.All changes to be backwards-compatible. The old flags and commands are deprecated but not removed. They will be removed before the 8.0 release.
Signed-off-by: deepthi deepthi@planetscale.com