Update reserved connection document#1779
Merged
harshit-gangal merged 5 commits intoprodfrom Jul 9, 2024
Merged
Conversation
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
✅ Deploy Preview for vitess ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
deepthi
reviewed
Jul 2, 2024
Comment on lines
-29
to
-32
| MySQL. As such, take note of the `SET` statements that your application's | ||
| MySQL connector and/or ORM sends to MySQL/`vtgate`. Or if those settings will | ||
| result in reserved connections being employed for some/all of the application's | ||
| sessions. |
Collaborator
There was a problem hiding this comment.
This needs to be updated in all affected versions. Which release did this change in?
Member
Author
There was a problem hiding this comment.
There is a flag which can be turn it off, so user can still have the impact of using reserved connection with set statement.
It is now deprecated for v21.
GuptaManan100
approved these changes
Jul 4, 2024
deepthi
reviewed
Jul 8, 2024
Collaborator
deepthi
left a comment
deepthi
left a comment
There was a problem hiding this comment.
Can you address my suggested changes? we can merge after that.
Co-authored-by: Deepthi Sigireddi <deepthi@planetscale.com> Signed-off-by: Harshit Gangal <harshit@planetscale.com>
Co-authored-by: Deepthi Sigireddi <deepthi@planetscale.com> Signed-off-by: Harshit Gangal <harshit@planetscale.com>
Co-authored-by: Deepthi Sigireddi <deepthi@planetscale.com> Signed-off-by: Harshit Gangal <harshit@planetscale.com>
Co-authored-by: Deepthi Sigireddi <deepthi@planetscale.com> Signed-off-by: Harshit Gangal <harshit@planetscale.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removed all the reference of
setstatement leading toreserved connectionas this is not the case anymore.Deprecation PR: vitessio/vitess#16280