deprecate queryserver-enable-settings-pool flag#16280
Merged
harshit-gangal merged 4 commits intovitessio:mainfrom Jun 28, 2024
Merged
deprecate queryserver-enable-settings-pool flag#16280harshit-gangal merged 4 commits intovitessio:mainfrom
harshit-gangal merged 4 commits intovitessio:mainfrom
Conversation
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
Contributor
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Tests
Documentation
New flags
If a workflow is added or modified:
Backward compatibility
|
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #16280 +/- ##
==========================================
+ Coverage 68.60% 68.62% +0.01%
==========================================
Files 1544 1544
Lines 198016 198008 -8
==========================================
+ Hits 135849 135875 +26
+ Misses 62167 62133 -34 ☔ View full report in Codecov by Sentry. |
systay
approved these changes
Jun 27, 2024
deepthi
approved these changes
Jun 27, 2024
Collaborator
|
I added the release notes label to prevent accidental merge. Once the requested textual change has been made, you may go ahead and remove the label and merge this PR. |
Co-authored-by: Deepthi Sigireddi <deepthi.sigireddi@gmail.com> Signed-off-by: Harshit Gangal <harshit@planetscale.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR deprecates the
queryserver-enable-settings-poolas this is not required to be changed by the user and has defaulted totruefrom v17 onwards. If disabled could lead to pool exhaustion. The changes are well-tested now and have remained default from v17.Related Issue(s)
Checklist
Deployment Notes