Conversation
Signed-off-by: Matt Lord <mattalord@gmail.com>
✅ Deploy Preview for vitess ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Signed-off-by: Matt Lord <mattalord@gmail.com>
Signed-off-by: Matt Lord <mattalord@gmail.com>
Signed-off-by: Matt Lord <mattalord@gmail.com>
Signed-off-by: Matt Lord <mattalord@gmail.com>
Signed-off-by: Matt Lord <mattalord@gmail.com>
mattlord
force-pushed
the
vrepl_reference
branch
from
d63d045 to
f33a50d
Compare
Signed-off-by: Matt Lord <mattalord@gmail.com>
Signed-off-by: Matt Lord <mattalord@gmail.com>
Signed-off-by: Matt Lord <mattalord@gmail.com>
mattlord
force-pushed
the
vrepl_reference
branch
from
39c75b9 to
826186c
Compare
Signed-off-by: Matt Lord <mattalord@gmail.com>
Signed-off-by: Matt Lord <mattalord@gmail.com>
mattlord
commented
Dec 6, 2022
3 tasks
rohit-nayak-ps
requested changes
Dec 14, 2022
Member
rohit-nayak-ps
left a comment
rohit-nayak-ps
left a comment
There was a problem hiding this comment.
Nice!
Noticed a few minor issues. Otherwise looks very good.
3 tasks
Signed-off-by: Matt Lord <mattalord@gmail.com>
Member
Author
|
Thanks, @rohit-nayak-ps ! I believe that I addressed your comments here: e02d88c |
Signed-off-by: Matt Lord <mattalord@gmail.com>
harshit-gangal
approved these changes
Dec 22, 2022
rohit-nayak-ps
requested changes
Dec 22, 2022
content/en/docs/16.0/reference/vreplication/tablet_selection.md
Outdated
Show resolved
Hide resolved
content/en/docs/16.0/reference/vreplication/tablet_selection.md
Outdated
Show resolved
Hide resolved
Signed-off-by: Matt Lord <mattalord@gmail.com>
Signed-off-by: Matt Lord <mattalord@gmail.com>
rohit-nayak-ps
approved these changes
Dec 22, 2022
Signed-off-by: Matt Lord <mattalord@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Documents: vitessio/vitess#11705 (likely some stragglers to be corrected in follow-ups as we review the full set of docs)
Fixes: #1242