Cutover user guide: remove references to VReplication v1 workflows#1187
Closed
rohit-nayak-ps wants to merge 1 commit intoprodfrom
Closed
Cutover user guide: remove references to VReplication v1 workflows#1187rohit-nayak-ps wants to merge 1 commit intoprodfrom
rohit-nayak-ps wants to merge 1 commit intoprodfrom
Conversation
✅ Deploy Preview for vitess ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
rohit-nayak-ps
force-pushed
the
remove-v1-refs-from-cutover-ug
branch
from
251c7b2 to
61dd2a1
Compare
Signed-off-by: Rohit Nayak <rohit@planetscale.com>
rohit-nayak-ps
force-pushed
the
remove-v1-refs-from-cutover-ug
branch
from
61dd2a1 to
0f466c9
Compare
deepthi
reviewed
Oct 21, 2022
| Note that running VDiff via vtctld can lead to vtctld consuming significantly more memory than usual. | ||
| We've found this to be around 1 GB plus, instead of the a few hundred MB that it normally uses. | ||
| If you run your vtctld in a memory limited container, you may want to take this into account. | ||
| Note that running VDiff via vtctld can lead to vtctld consuming significantly more memory than usual. |
Collaborator
There was a problem hiding this comment.
There is a lot of info about VDiff here, but
- there doesn't seem to be an actual example command
- Let us provide VDiff v2 as the example and say that you can fall back to v1 if necessary.
- After that we we can talk about the limitations of VDiff v1 if we still want to.
Member
There was a problem hiding this comment.
@deepthi IMO, I'd rather come back to this when making VDiff2 become the default, i.e. VDiff2 becomes VDiff and VDiff becomes VDiff1. Is that OK? Otherwise I can move your comment here, where it's a more general content review: https://github.com/vitessio/website/pull/1267/files#diff-b84db5aebf7f99b2b669bb8ba06ff5f84052a434e011267d67e4803d4dd2732a
Member
There was a problem hiding this comment.
| @@ -646,41 +494,3 @@ vtctlclient --server vtctld.host:15999 MoveTables -- Cancel targetkeyspace.workf | |||
| 1. Drop the tables involved in the MoveTables in the new keyspace (targetkeyspace) | |||
| 2. Remove the workflows related to the MoveTables operation | |||
| 3. Clean up the routing rules. Applications pointed to the targetkeyspace will no longer be transparently redirected to the sourcekeyspace | |||
Collaborator
There was a problem hiding this comment.
Link to routing rules commands here?
Member
|
I'm closing this for now as I made the same removals in: #1267. I removed the v1 content in v16 only as that’s when the v1 commands were removed, and I added a warning to v15-. If I'm missing something we can always re-open this and/or copy some changes over there. |
mattlord
added a commit
that referenced
this pull request
Dec 6, 2022
Signed-off-by: Matt Lord <mattalord@gmail.com>
mattlord
added a commit
that referenced
this pull request
Dec 22, 2022
* Remove vrepl v1 commands in v16 and add removal warning in v15- Signed-off-by: Matt Lord <mattalord@gmail.com> * Remove more vrepl v1 command content Signed-off-by: Matt Lord <mattalord@gmail.com> * MoveTables page Signed-off-by: Matt Lord <mattalord@gmail.com> * Reshard page Signed-off-by: Matt Lord <mattalord@gmail.com> * Conslidate MoveTables docs Signed-off-by: Matt Lord <mattalord@gmail.com> * Consolidate Reshard page Signed-off-by: Matt Lord <mattalord@gmail.com> * Update materialize Signed-off-by: Matt Lord <mattalord@gmail.com> * Another round of changes Signed-off-by: Matt Lord <mattalord@gmail.com> * Another round Signed-off-by: Matt Lord <mattalord@gmail.com> * Add Complete action to MoveTables and Reshard Signed-off-by: Matt Lord <mattalord@gmail.com> * Syncing up with #1187 Signed-off-by: Matt Lord <mattalord@gmail.com> * Address review comments Signed-off-by: Matt Lord <mattalord@gmail.com> * Add VTGate VStream info to tablet selection doc Signed-off-by: Matt Lord <mattalord@gmail.com> * Tweaks and corrections to tablet selection Signed-off-by: Matt Lord <mattalord@gmail.com> * One more... Signed-off-by: Matt Lord <mattalord@gmail.com> * Moar minor tablet selection tweaks Signed-off-by: Matt Lord <mattalord@gmail.com> Signed-off-by: Matt Lord <mattalord@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What the title says.