Skip to content

docker: cleanup of release.sh#9867

Merged
derekperkins merged 3 commits intovitessio:mainfrom
derekperkins:docker-release
Mar 30, 2022
Merged

docker: cleanup of release.sh#9867
derekperkins merged 3 commits intovitessio:mainfrom
derekperkins:docker-release

Conversation

@derekperkins
Copy link
Member

@derekperkins derekperkins commented Mar 11, 2022

This cleans up the release process for all the docker images inside /docker/k8s

  • upgrades to v13 + defaults the base image to bullseye (discussed with @mattlord here)
  • explicitly build amd64 images (I accidentally pushed arm64 images from a new Mac)
  • change paths to run in place - prior to this, it required to be executed in the /docker/k8s directory as ../release.sh. That was just an artifact after it moved from the since deleted /helm directory

Signed-off-by: Derek Perkins <derek@derekperkins.com>
Copy link
Member

@mattlord mattlord left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I like the explicit platform flags, especially with coming ARM support in #9830 🙂 (will review that one tomorrow)

Signed-off-by: Derek Perkins <derek@derekperkins.com>
prior to this, it required to be executed in the /docker/k8s directory as ../release.sh

Signed-off-by: Derek Perkins <derek@derekperkins.com>
@derekperkins
Copy link
Member Author

That force push was adding the explicit platform flag to the initial docker pull command. I'll merge once tests pass

@derekperkins derekperkins merged commit cf942c0 into vitessio:main Mar 30, 2022
@derekperkins derekperkins deleted the docker-release branch March 30, 2022 23:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants