Skip to content

docker: k8s release process updates#9561

Merged
derekperkins merged 3 commits intovitessio:mainfrom
derekperkins:release-updates
Jan 31, 2022
Merged

docker: k8s release process updates#9561
derekperkins merged 3 commits intovitessio:mainfrom
derekperkins:release-updates

Conversation

@derekperkins
Copy link
Member

This is an update to the release process for the /docker/k8s/... images for individual binaries. This should all be pushed into Docker Hub configuration, and then release.sh can be removed I just haven't had the chance to do it. I still manually build and publish images from my machine for every release.

Signed-off-by: Derek Perkins <derek@nozzle.io>
Signed-off-by: Derek Perkins <derek@nozzle.io>
@derekperkins
Copy link
Member Author

None of the failing tests are related to these changes

@deepthi deepthi requested review from frouioui and mattlord January 27, 2022 22:57
Copy link
Member

@mattlord mattlord left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll need to tweak the equality conditions but otherwise it seems fine. I'm not familiar with the context here though like you are. Is there anything related to this that we should do as part of the upcoming 13.0-RC and/or 13.0 (GA) releases?

Thank you!

Signed-off-by: Derek Perkins <derek@nozzle.io>
@derekperkins
Copy link
Member Author

Thanks for the review. The only thought I have about v13 is about the default debian version. I'm publishing both buster and bullseye specific images, but the unspecified tag v12.0.3 currently matches buster. I was thinking about switching that to bullseye for v13.

IIRC, nothing in official Vitess documentation uses these anymore, but anyone running from the original helm charts would use these. Docker Hub shows a few hundred thousand downloads on average for most of these, but I'm not sure how active they are recently. FWIW, I didn't publish the log4j images until I submitted this PR, so nobody was beating down the door for the updates.

image

@mattlord mattlord self-requested a review January 29, 2022 05:11
@mattlord
Copy link
Member

Thanks for the review. The only thought I have about v13 is about the default debian version. I'm publishing both buster and bullseye specific images, but the unspecified tag v12.0.3 currently matches buster. I was thinking about switching that to bullseye for v13.

I would default to pairing latest GA with latest GA here. So Vitess 13.0 on bullseye.

IIRC, nothing in official Vitess documentation uses these anymore, but anyone running from the original helm charts would use these. Docker Hub shows a few hundred thousand downloads on average for most of these, but I'm not sure how active they are recently. FWIW, I didn't publish the log4j images until I submitted this PR, so nobody was beating down the door for the updates.

Those have been deprecated in previous releases and entirely removed in v13 AFAIK. So I think we're OK there.

THANK YOU!

@derekperkins derekperkins merged commit 9a2652d into vitessio:main Jan 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants