Skip to content

Add HexVal and HexNum type support to evalengine.Expr#9616

Closed
mattlord wants to merge 1 commit intovitessio:mainfrom
planetscale:evalengine_hextypesupport
Closed

Add HexVal and HexNum type support to evalengine.Expr#9616
mattlord wants to merge 1 commit intovitessio:mainfrom
planetscale:evalengine_hextypesupport

Conversation

@mattlord
Copy link
Copy Markdown
Member

@mattlord mattlord commented Feb 2, 2022

Description

In this commit 0d1a5e5, which was part of #9351, we broke HexVal and HexNum type support with Vindexes.

More specifically, HexVal and HexNum type support in vindex functions was lost in the transition from sqltypes.PlanValue to evalengine.Expr.

This work aims to add support for the HexVal and HexNum types in evalengine.Expr.

Related Issue(s)

Checklist

  • Should this PR be backported? YES, but ONLY to release-13.0
  • Tests were added or are not required
  • Documentation was added or is not required

Signed-off-by: Matt Lord <mattalord@gmail.com>
@mattlord mattlord force-pushed the evalengine_hextypesupport branch from 25f602c to 560e68e Compare February 2, 2022 04:13
@vmg vmg mentioned this pull request Feb 3, 2022
3 tasks
@mattlord
Copy link
Copy Markdown
Member Author

mattlord commented Feb 3, 2022

This is being replaced by: #9623

@mattlord mattlord closed this Feb 3, 2022
@mattlord mattlord deleted the evalengine_hextypesupport branch February 3, 2022 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant