Merged
Conversation
vmg
requested changes
Dec 10, 2021
vmg
approved these changes
Dec 10, 2021
frouioui
approved these changes
Dec 13, 2021
Member
frouioui
left a comment
frouioui
left a comment
There was a problem hiding this comment.
awesome work, this is really exciting
go/vt/vtgate/engine/limit.go
Outdated
Comment on lines
202
to
206
Member
There was a problem hiding this comment.
It would be nicer to print the raw value instead of printing type+value, like: print 1 instead of INT64(1)
Signed-off-by: Andres Taylor <andres@planetscale.com>
Signed-off-by: Andres Taylor <andres@planetscale.com>
Signed-off-by: Andres Taylor <andres@planetscale.com>
Signed-off-by: Andres Taylor <andres@planetscale.com>
Signed-off-by: Andres Taylor <andres@planetscale.com>
Signed-off-by: Andres Taylor <andres@planetscale.com>
Signed-off-by: Andres Taylor <andres@planetscale.com>
Signed-off-by: Andres Taylor <andres@planetscale.com>
Signed-off-by: Andres Taylor <andres@planetscale.com>
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
…ead of plan value Signed-off-by: Harshit Gangal <harshit@planetscale.com>
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
…ne convert expression Signed-off-by: Harshit Gangal <harshit@planetscale.com>
Signed-off-by: Andres Taylor <andres@planetscale.com>
…ction gen4 and tabletserver code Signed-off-by: Harshit Gangal <harshit@planetscale.com>
Signed-off-by: Alkin Tezuysal <alkin.tezuysal@gmail.com>
Signed-off-by: Alkin Tezuysal <alkin.tezuysal@gmail.com>
Signed-off-by: Andres Taylor <andres@planetscale.com>
Signed-off-by: Andres Taylor <andres@planetscale.com>
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
harshit-gangal
force-pushed
the
more-evalengine
branch
from
43b6b42 to
594bba4
Compare
harshit-gangal
approved these changes
Dec 14, 2021
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
sqltypes.PlanValuehas reached the end of its usefulness, and is being replaced byevalengine.This PR updates engine primitives to use evalengine.