Skip to content

add tableacl monitoring#927

Merged
yaoshengzhe merged 1 commit intovitessio:masterfrom
yaoshengzhe:fix_tableacl_monitoring
Jul 29, 2015
Merged

add tableacl monitoring#927
yaoshengzhe merged 1 commit intovitessio:masterfrom
yaoshengzhe:fix_tableacl_monitoring

Conversation

@yaoshengzhe
Copy link
Contributor

  1. Add three varzs TableACLAllowed, TableACLDenied and TableACLPseudoDenied.
  2. Each has labels: TableName, TableGroup, PlanID and Username
  3. TableACLPseudoDenied varz will be set when a query would have been denied
    but wan't because the system is in dry-run mode or because the caller is a
    superuser.

1. Add three varzs TableACLAllowed, TableACLDenied and TableACLPseudoDenied.
2. Each has labels: TableName, TableGroup, PlanID and Username
3. TableACLPseudoDenied varz will be set when a query would have been denied
   but wan't because the system is in dry-run mode or because the caller is a
   superuser.
@yaoshengzhe
Copy link
Contributor Author

any comments ?

@alainjobart
Copy link
Contributor

LGTM Sugu can look at it later

@sougou
Copy link
Contributor

sougou commented Jul 28, 2015

LGTM
I'm still not too familiar with the feature, but the approach to achieve what you wanted seems good.

yaoshengzhe added a commit that referenced this pull request Jul 29, 2015
@yaoshengzhe yaoshengzhe merged commit fe8d9d1 into vitessio:master Jul 29, 2015
@yaoshengzhe yaoshengzhe deleted the fix_tableacl_monitoring branch July 29, 2015 18:39
systay pushed a commit to planetscale/vitess that referenced this pull request Aug 19, 2022
…vitessio#927)

Add GetFullStatus RPC to vtctld

Signed-off-by: Manan Gupta <manan@planetscale.com>

Co-authored-by: Deepthi Sigireddi <deepthi@planetscale.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants