Add GetFullStatus RPC to vtctld#10905
Merged
deepthi merged 6 commits intovitessio:mainfrom Aug 4, 2022
Merged
Conversation
Signed-off-by: Manan Gupta <manan@planetscale.com>
Signed-off-by: Manan Gupta <manan@planetscale.com>
Signed-off-by: Manan Gupta <manan@planetscale.com>
GuptaManan100
added
Type: Enhancement
GuptaManan100
requested review from
ajm188,
deepthi,
doeg and
notfelineit
as code owners
Contributor
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Bug fixes
Non-trivial changes
New/Existing features
Backward compatibility
|
ajm188
reviewed
Aug 1, 2022
Contributor
ajm188
left a comment
ajm188
left a comment
There was a problem hiding this comment.
code looks good to me, just some nitpicks on the code organization to match existing stuff
Signed-off-by: Manan Gupta <manan@planetscale.com>
Signed-off-by: Manan Gupta <manan@planetscale.com>
… have this rpc Signed-off-by: Manan Gupta <manan@planetscale.com>
GuptaManan100
commented
Aug 3, 2022
Contributor
Author
GuptaManan100
left a comment
GuptaManan100
left a comment
There was a problem hiding this comment.
I also had to move the FullStatus test to newfeatures since the old vtctld don't have that RPC
systay
pushed a commit
to planetscale/vitess
that referenced
this pull request
Aug 19, 2022
…vitessio#927) Add GetFullStatus RPC to vtctld Signed-off-by: Manan Gupta <manan@planetscale.com> Co-authored-by: Deepthi Sigireddi <deepthi@planetscale.com>
timvaillancourt
pushed a commit
to slackhq/vitess
that referenced
this pull request
May 20, 2024
Add GetFullStatus RPC to vtctld
4 tasks
timvaillancourt
added a commit
to slackhq/vitess
that referenced
this pull request
May 21, 2024
…#357) Add GetFullStatus RPC to vtctld Co-authored-by: Deepthi Sigireddi <deepthi@planetscale.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds the
GetFullStatusRPC to vtctld. This RPC exports the TabletManagerClient RPCFullStatusso it is possible to call it from the vtctld server.This is required for VTAdmin to display the information provided by this RPC so that it can reach parity with the orchestrator UI.
Related Issue(s)
Checklist
Deployment Notes