Ensure that hex query predicates are normalized for planner cache#9163
Closed
mattlord wants to merge 3 commits intovitessio:release-10.0from
Closed
Ensure that hex query predicates are normalized for planner cache#9163mattlord wants to merge 3 commits intovitessio:release-10.0from
mattlord wants to merge 3 commits intovitessio:release-10.0from
Conversation
…nQueries Ensure that hex query predicates are normalized for planner cache Signed-off-by: Matt Lord <mattalord@gmail.com>
This is done by properly managing the HexVal BindVar: - The "raw" value is what was seen in the query - The ToBytes value returns they bytes that mysql would return Signed-off-by: Matt Lord <mattalord@gmail.com> Signed-off-by: Gary Edgar <gary@planetscale.com>
Signed-off-by: Matt Lord <mattalord@gmail.com> Signed-off-by: Gary Edgar <gary@planetscale.com> Signed-off-by: Gary Edgar <gary@planetscale.com>
DeathBorn
pushed a commit
to vinted/vitess
that referenced
this pull request
Jan 27, 2023
…lizeHexValuesInQueries vitessio@322ac09 using vitessio#9163 as a guide Merge pull request vitessio#9118 from planetscale/NormalizeHexValuesInQueries Ensure that hex query predicates are normalized for planner cache Signed-off-by: Matt Lord <mattalord@gmail.com> Signed-off-by: Vilius Okockis <vilius.okockis@vinted.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.