Skip to content

Ensure that hex query predicates are normalized for planner cache#9163

Closed
mattlord wants to merge 3 commits intovitessio:release-10.0from
planetscale:10-0-2-BP-NormalizeHexValuesInQueries
Closed

Ensure that hex query predicates are normalized for planner cache#9163
mattlord wants to merge 3 commits intovitessio:release-10.0from
planetscale:10-0-2-BP-NormalizeHexValuesInQueries

Conversation

@mattlord
Copy link
Copy Markdown
Member

@mattlord mattlord commented Nov 9, 2021

No description provided.

…nQueries

Ensure that hex query predicates are normalized for planner cache

Signed-off-by: Matt Lord <mattalord@gmail.com>
This is done by properly managing the HexVal BindVar:
  - The "raw" value is what was seen in the query
  - The ToBytes value returns they bytes that mysql would return

Signed-off-by: Matt Lord <mattalord@gmail.com>

Signed-off-by: Gary Edgar <gary@planetscale.com>
Signed-off-by: Matt Lord <mattalord@gmail.com>

Signed-off-by: Gary Edgar <gary@planetscale.com>

Signed-off-by: Gary Edgar <gary@planetscale.com>
@mattlord mattlord closed this Jan 24, 2022
DeathBorn pushed a commit to vinted/vitess that referenced this pull request Jan 27, 2023
…lizeHexValuesInQueries vitessio@322ac09 using vitessio#9163 as a guide

Merge pull request vitessio#9118 from planetscale/NormalizeHexValuesInQueries

Ensure that hex query predicates are normalized for planner cache

Signed-off-by: Matt Lord <mattalord@gmail.com>
Signed-off-by: Vilius Okockis <vilius.okockis@vinted.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants