Ensure that hex query predicates are normalized for planner cache#9145
Merged
deepthi merged 1 commit intovitessio:release-12.0from Nov 9, 2021
Merged
Conversation
mattlord
added
Type: Bug
Component: Query Serving
Backport
mattlord
requested review from
GuptaManan100,
harshit-gangal,
pH14 and
systay
as code owners
mattlord
requested review from
frouioui
and removed request for
GuptaManan100,
harshit-gangal and
pH14
frouioui
approved these changes
Nov 4, 2021
…nQueries Ensure that hex query predicates are normalized for planner cache Signed-off-by: Matt Lord <mattalord@gmail.com>
mattlord
force-pushed
the
NormalizeHexValuesInQueries-Backport12.0
branch
from
6360b7b to
322ac09
Compare
deepthi
changed the title
Collaborator
|
Approving the backport based on a report that this is affecting production for a user. |
3 tasks
DeathBorn
pushed a commit
to vinted/vitess
that referenced
this pull request
Jan 27, 2023
…lizeHexValuesInQueries vitessio@322ac09 using vitessio#9163 as a guide Merge pull request vitessio#9118 from planetscale/NormalizeHexValuesInQueries Ensure that hex query predicates are normalized for planner cache Signed-off-by: Matt Lord <mattalord@gmail.com> Signed-off-by: Vilius Okockis <vilius.okockis@vinted.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ℹ️ This is a backport of #9118
Description
We were not normalizing hex values of either format:
0x01x'73757265'This had a major performance impact in workloads where hex query predicates are used in common queries as we could not leverage the query planner cache. This work normalizes them.
Related Issue(s)
#9101
#9118
Checklist