remove panic out of queryservice#906
Merged
yaoshengzhe merged 1 commit intovitessio:masterfrom Jul 23, 2015
yaoshengzhe:fix_remove_panic_in_queryservice
Merged
remove panic out of queryservice#906yaoshengzhe merged 1 commit intovitessio:masterfrom yaoshengzhe:fix_remove_panic_in_queryservice
yaoshengzhe merged 1 commit intovitessio:masterfrom
yaoshengzhe:fix_remove_panic_in_queryservice
Conversation
1. Remove panics out of QueryExecutor and return error instead. 2. Some places like TxPool, CachePool, SchemaInfo still panics and will be captured and handled in SqlQuery.
Contributor
|
LGTM. Nice work! |
yaoshengzhe
added a commit
that referenced
this pull request
Jul 23, 2015
…vice remove panic out of queryservice
systay
pushed a commit
to planetscale/vitess
that referenced
this pull request
Aug 19, 2022
…ommand (vitessio#10900) (vitessio#906) * Online DDL: migration state transitions to 'cancelled' after CANCEL command Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com> * allow 'cancelled' state in vrepl suite Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com> * allow 'cancelled' state in vrepl suite Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com> * expect 'cancelled' state Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com> * expect 'cancelled' state Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com> * excessive check for error Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com> * expect 'cancelled' state Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
and handled in SqlQuery.