tabletserver: retry streaming query on conn error

[sougou]

@erzel
Streaming queries have recently become killable due to context
changes. So, a connection could potentially be dead due to a
previous query kill. So, we should retry streaming queries also
if we get a connection error.

[michael-berlin]

Sugu, you accidentally removed the execution bits from test.go in your first commit.

Can you please restore it?

This is probably the easiest way:

# Make sure your branch is clear and you don't have pending changes.
git update-index --chmod=+x test.go
git commit

Thanks!

[erzel]

Review status: 0 of 2 files reviewed at latest revision, 1 unresolved discussion.

---

go/vt/tabletserver/dbconn.go, line 132 [r1] (raw file):
Shouldn't it be dbconn.Stream in the error message? Also, wouldn't a "panic" be better here?

---

Comments from the review on Reviewable.io

[sougou]

Review status: 0 of 2 files reviewed at latest revision, 1 unresolved discussion, some commit checks broke.

---

go/vt/tabletserver/dbconn.go, line 132 [r1] (raw file):
Done.
This used to be a panic until @aaijazi changed this as part of his error cleanup, but I don't remember the reasons any more.

---

Comments from the review on Reviewable.io

[aaijazi]

go/vt/tabletserver/dbconn.go, line 132 [r1] (raw file):
I have no idea either. Seems like this PR was when it changed: #906

---

Comments from the review on Reviewable.io

[erzel]

Review status: 0 of 2 files reviewed at latest revision, 1 unresolved discussion, some commit checks broke.

---

go/vt/tabletserver/dbconn.go, line 132 [r1] (raw file):
IMHO this should be a panic. LGTM otherwise.

---

Comments from the review on Reviewable.io

[sougou]

Review status: 0 of 2 files reviewed at latest revision, 1 unresolved discussion.

---

go/vt/tabletserver/dbconn.go, line 132 [r1] (raw file):
Done.

---

Comments from the review on Reviewable.io

[sougou]

LGTM
(proxy-approving for @erzel)

[sougou]

Reviewed 1 of 1 files at r2, 1 of 1 files at r4.
Review status: all files reviewed at latest revision, 1 unresolved discussion.

---

Comments from the review on Reviewable.io

[sougou]

Review status: all files reviewed at latest revision, 1 unresolved discussion.

---

go/vt/tabletserver/dbconn.go, line 132 [r1] (raw file):
Done.

---

Comments from the review on Reviewable.io

[sougou]

Review status: all files reviewed at latest revision, all discussions resolved.

---

go/vt/tabletserver/dbconn.go, line 132 [r1] (raw file):
Looks like anyone who said anything has to approve. So, I'm going to override knowing that we're all in agreement.

---

Comments from the review on Reviewable.io

[aaijazi]

http://www.reactiongifs.com/wp-content/uploads/2013/09/confidence.gif

---

Comments from the review on Reviewable.io

[sougou]

LGTM
again... (apologies for the spam)

[michael-berlin]

I think one LGTM is enough.

If I understood @enisoc correctly, you could also just merge changes yourself since you're an admin of our repository.