[vtctl] hidden commands, plus misc tidying#9005
Merged
ajm188 merged 3 commits intovitessio:mainfrom Oct 18, 2021
Merged
Conversation
added 3 commits
October 15, 2021 07:33
Signed-off-by: Andrew Mason <amason@slack-corp.com>
Signed-off-by: Andrew Mason <amason@slack-corp.com>
Signed-off-by: Andrew Mason <amason@slack-corp.com>
doeg
approved these changes
Oct 15, 2021
doeg
reviewed
Oct 15, 2021
| @@ -1 +0,0 @@ | |||
| package vtctl | |||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR began as a continuation of #8967, adding a new
hiddenfield to the command struct and using that to hide commands from showing up invtctl helprather than doing prefix matching on help text, and ... then I cleaned up some import sorting thatgoimportsdoes not do and also saw a now-empty test file (which was emptied as part of #8134).Related Issue(s)
Checklist
Deployment Notes