Merged
Conversation
doeg
approved these changes
Oct 9, 2021
Contributor
doeg
left a comment
There was a problem hiding this comment.
The end-result is so readable!
Signed-off-by: Andrew Mason <amason@slack-corp.com>
8d4f2cf to
933908e
Compare
Contributor
Author
Agreed, and done.
Nope, I will port it over there as well! |
933908e to
186f599
Compare
Signed-off-by: Andrew Mason <amason@slack-corp.com>
186f599 to
3186b12
Compare
ajm188
pushed a commit
to ajm188/vitess
that referenced
this pull request
Oct 15, 2021
[vtctl] command deprecations Signed-off-by: Andrew Mason <amason@slack-corp.com>
This was referenced Oct 15, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds fields to the
commandstruct to support more formalized deprecation of commands. Unfortunately this required me to update every single command, because we weren't using keyed structs, but that is now fixed as well.Examples:
Related Issue(s)
Fixes #8953.
Checklist
Deployment Notes