Support MariaDB with SHOW vitess_replication_status#8985
Merged
deepthi merged 1 commit intovitessio:release-12.0from Oct 19, 2021
Merged
Conversation
When adding this command I leveraged the SHOW SLAVE STATUS command against the database instances because that was the lowest common denominator across our supported databases -- MariaDB did not have the replication status related performance_schema tables. BUT, what I didn't realize at the time was that MariaDB has added columns to the SHOW SLAVE/REPLICA STATUS output and some of these new columns were injected into the middle of the schema rather than appended. This means that in order to support MariaDB with this command we need to reference the column values by name rather than by index. See: - https://dev.mysql.com/doc/refman/en/replication-administration-status.html - https://mariadb.com/kb/en/show-replica-status/ Note: once all supported databases support the SHOW REPLICA STATUS query then we can make the inclusive naming changes. Signed-off-by: Matt Lord <mattalord@gmail.com>
mattlord
force-pushed
the
ShowVitessReplicationStatusMariaDB
branch
from
990492e to
15f905b
Compare
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When adding this command (in #8900) I leveraged the
SHOW SLAVE STATUScommand against the database instances because that was the lowest common denominator across our supported databases -- MariaDB did not have the replication status relatedperformance_schematables.But, what I didn't realize at the time was that MariaDB has added columns to the
SHOW SLAVE/REPLICA STATUSoutput and some of these new columns were injected into the middle of the schema rather than appended. This means that in order to support MariaDB with this Vitess command we need to reference the column values by name rather than by index. See:Related Issue(s)
Forward port is here: #8986
Checklist