Add SHOW VITESS_REPLICATION_STATUS Query Support#8900
Merged
deepthi merged 11 commits intovitessio:mainfrom Oct 4, 2021
Merged
Add SHOW VITESS_REPLICATION_STATUS Query Support#8900deepthi merged 11 commits intovitessio:mainfrom
deepthi merged 11 commits intovitessio:mainfrom
Conversation
62c4765 to
16866c8
Compare
17217a2 to
fbbe52b
Compare
systay
reviewed
Sep 29, 2021
af59da8 to
42d5490
Compare
sougou
approved these changes
Sep 29, 2021
Contributor
sougou
left a comment
There was a problem hiding this comment.
I think this is a good start. We should eventually add more info, like running state, error, etc. There is some overlap with the experimental VExec command, but I think that one didn't quite take off like we expected.
Tagging @systay @harshit-gangal to look at the parser side.
Optimistically approving.
0bf7524 to
2cab7cc
Compare
f7bc1d7 to
ae7935a
Compare
systay
reviewed
Sep 30, 2021
be5cbdf to
5beca6c
Compare
3d0b283 to
01dd57b
Compare
0624530 to
eb86e79
Compare
cef7db3 to
76b6d39
Compare
This can show replication health for the cluster. Signed-off-by: Matt Lord <mattalord@gmail.com>
Signed-off-by: Matt Lord <mattalord@gmail.com>
Signed-off-by: Matt Lord <mattalord@gmail.com>
Signed-off-by: Matt Lord <mattalord@gmail.com>
(And try and put parser additions in lexicographical order) Signed-off-by: Matt Lord <mattalord@gmail.com>
Signed-off-by: Matt Lord <mattalord@gmail.com>
…alls Signed-off-by: Matt Lord <mattalord@gmail.com>
Signed-off-by: Matt Lord <mattalord@gmail.com>
Signed-off-by: Matt Lord <mattalord@gmail.com>
Signed-off-by: Matt Lord <mattalord@gmail.com>
And use de-facto standard of CamelCase for column names in Vitess query language extension results. Signed-off-by: Matt Lord <mattalord@gmail.com>
76b6d39 to
f623b12
Compare
deepthi
approved these changes
Oct 4, 2021
Collaborator
deepthi
left a comment
There was a problem hiding this comment.
This is a nice enhancement. Thank you!
Member
Author
|
Bug fix in: #8950 |
This was referenced Oct 13, 2021
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
What
The new
SHOW VITESS_REPLICATION_STATUScommand/query shows the MySQL replica/replication (notvreplication) health for the vitess deployment. It returns a row for eachREPLICAandRDONLYtablet in the topology -- with support for filtering byKeyspace/Shardusing aLIKEclause -- providing relevant health and status information, including the current throttler status for the tablet.Why
This allows applications -- which are generally interfacing with Vitess through a VTGate -- to alter behavior based on the replication state. They can e.g. decide to back off or delay some planned batch work if replication lag is high or if the tablet throttler is configured and shows that there are too many requests coming in.
This also offers humans and other tooling an easy and convenient way to examine the replication health and related status of the entire Vitess topology, a Keyspace, or a Shard.
Examples
Signed-off-by: Matt Lord mattalord@gmail.com
Related Issue(s)
#6984
Checklist
Deployment Notes
I'd like to flag this as
experimentalso that we can get it into 12.0 but have some added flexibility in modifying/improving it based on user feedback.