multishard autocommit should work for bypass routing#8428
Merged
harshit-gangal merged 3 commits intomainfrom Jul 13, 2021
Merged
multishard autocommit should work for bypass routing#8428harshit-gangal merged 3 commits intomainfrom
harshit-gangal merged 3 commits intomainfrom
Conversation
demmer
requested review from
GuptaManan100,
harshit-gangal and
systay
as code owners
7 tasks
Member
|
This change looks good to me. @demmer could you look at the conflicts and push again? Also, extra pair of eyes from @GuptaManan100 or @systay would be great. |
Signed-off-by: Michael Demmer <mdemmer@slack-corp.com>
Signed-off-by: Michael Demmer <mdemmer@slack-corp.com>
Signed-off-by: Michael Demmer <mdemmer@slack-corp.com>
demmer
force-pushed
the
multishard-autocommit-should-work-for-scatter-dmls
branch
from
d6fb25d to
b56b89f
Compare
Member
Author
|
I fixed the conflicts and re-pushed. Not sure why all the CI is failing. |
GuptaManan100
added
Component: Query Serving
Type: Enhancement
Collaborator
Guessing that was the "pr-labels" check that was failing. Manan added labels to the PR, so nothing to do 👍 |
harshit-gangal
approved these changes
Jul 13, 2021
harshit-gangal
deleted the
multishard-autocommit-should-work-for-scatter-dmls
branch
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Parse and extract the multishard autocommit query directive in the bypass routing plan builder.
We (Slack) noticed that routing a DML to the keyrange target
[-], performance timings implied that the multishard autocommit query directive wasn't being honored when routing the query.This change makes the query directive take effect when DMLs are force routed to a particular shard or keyrange.
Checklist
Deployment Notes
None