This repository was archived by the owner on Dec 16, 2022. It is now read-only.
Closed
Conversation
Signed-off-by: Michael Demmer <mdemmer@slack-corp.com>
Signed-off-by: Michael Demmer <mdemmer@slack-corp.com> Signed-off-by: Andrew Mason <amason@slack-corp.com>
Signed-off-by: Michael Demmer <mdemmer@slack-corp.com> Signed-off-by: Andrew Mason <amason@slack-corp.com>
demmer
approved these changes
Jul 7, 2021
Collaborator
demmer
left a comment
demmer
left a comment
There was a problem hiding this comment.
Code looks great!
I couldn't have written it better myself :)
|
TIL how to cherry pick multiple commits. 😄 |
guidoiaquinti
approved these changes
Jul 8, 2021
Author
|
closing and reopening with a different branch because i messed up my numbering 🤦 |
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
cherry-picks vitessio#8428
generated via
git cherry-pick d27354c^..d6fb25dRelated Issue(s)
Checklist
Deployment Notes
Impacted Areas in Vitess
Components that this PR will affect: