[workflow] Add vreplication_log data to workflow protos, and VtctldServer.GetWorkflows method#8261
Merged
ajm188 merged 6 commits intovitessio:mainfrom Jun 13, 2021
Merged
Conversation
ajm188
added
Type: Feature
Component: Cluster management
Component: VReplication
Component: VTAdmin
doeg
approved these changes
Jun 4, 2021
Contributor
doeg
left a comment
doeg
left a comment
There was a problem hiding this comment.
This looks really really great to me. I messed with it a bit locally and the data model is purrfect for what I need. 😈
The vexec/query planner parts seem straightforward to me, but you might want another set of eyes on the particularly Vitess-y parts. Up to you!
Thank youuuu!!!
go/vt/vtctl/workflow/server.go
Outdated
added 6 commits
June 13, 2021 14:46
The intention here is that, for `vreplication_log` queries, we will want to have different `stream_id` bindvars for each target tablet in the query. Therefore in the next set of changes, we'll provided a second implementation of `QueryPlan` that allows a different query (with different bind vars) to be run on each target. Signed-off-by: Andrew Mason <amason@slack-corp.com>
Signed-off-by: Andrew Mason <amason@slack-corp.com>
Signed-off-by: Andrew Mason <amason@slack-corp.com>
Signed-off-by: Andrew Mason <amason@slack-corp.com>
Signed-off-by: Andrew Mason <amason@slack-corp.com>
Signed-off-by: Andrew Mason <amason@slack-corp.com>
ajm188
force-pushed
the
am_vreplication_log
branch
from
4131b2d to
24b84a4
Compare
doeg
approved these changes
Jun 13, 2021
ajm188
pushed a commit
to tinyspeck/vitess
that referenced
this pull request
Jun 15, 2021
[workflow] Add vreplication_log data to workflow protos, and `VtctldServer.GetWorkflows` method Signed-off-by: Andrew Mason <amason@slack-corp.com>
ajm188
pushed a commit
to tinyspeck/vitess
that referenced
this pull request
Jul 23, 2021
[workflow] Add vreplication_log data to workflow protos, and `VtctldServer.GetWorkflows` method Signed-off-by: Andrew Mason <amason@slack-corp.com>
8 tasks
33 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This enhances the
GetWorkflowsendpoint in VtcltdServer to also, on a best-effort basis, query the_vt.vreplication_logtable for all streams involved in each workflow. On tablets that are running with older versions of vitess (which do not have the log table), then the log fetch queries should fail, and we will setLogFetchErroron each stream in each workflow in the response, but the overall RPC will still be non-error.Here is this change running, accessed via vtadmin, on the
303_reshardlocal example:Related Issue(s)
Closes #8260
Checklist
Deployment Notes