This repository was archived by the owner on Dec 16, 2022. It is now read-only.
Slack vitess 9 2021.06.07r13.vtctld#217
Merged
ajm188 merged 10 commits intoslack-vitess-9-2021.06.07r10.vtctldfrom Jun 16, 2021
Merged
Slack vitess 9 2021.06.07r13.vtctld#217ajm188 merged 10 commits intoslack-vitess-9-2021.06.07r10.vtctldfrom
ajm188 merged 10 commits intoslack-vitess-9-2021.06.07r10.vtctldfrom
Conversation
added 5 commits
June 14, 2021 21:23
[workflow] Add vreplication_log data to workflow protos, and `VtctldServer.GetWorkflows` method Signed-off-by: Andrew Mason <amason@slack-corp.com>
In upstream (where the previous commit was cherry-picked from), all of the `New<columntype>` functions take a `string` argument, but previously (and therefore in our vtctld branch) they took a `[]byte`. Signed-off-by: Andrew Mason <amason@slack-corp.com>
Steps taken: 1. `git checkout upstream/main -- go/vt/vtctl/grpcvtctldserver/server_test.go` 2. `git checkout upstream/main -- go/vt/vtctl/grpcvtctldserver/testutil` 3. Replace imports of `google.golang.org/protobuf/proto` with `github.com/golang/protobuf/proto`, as we haven't taken the protobuf upgrade yet 4. Remove all types referenced in the tests that we haven't added to vtctldatapb yet Note: at the time, `upstream/main` resolved to `83dfb9aa59ce47a313ecb7bc12804298e76d350c`. Signed-off-by: Andrew Mason <amason@slack-corp.com>
…vschemas [vtctld] Add GetSrvVSchemas command Signed-off-by: Andrew Mason <amason@slack-corp.com>
…info [vtctldserver] Add additional backup info fields Signed-off-by: Andrew Mason <amason@slack-corp.com>
added 4 commits
June 15, 2021 17:32
…le/BackupEngine interfaces to support populating BackupInfo.Status Signed-off-by: Andrew Mason <amason@slack-corp.com>
Signed-off-by: Andrew Mason <amason@slack-corp.com>
Signed-off-by: Andrew Mason <amason@slack-corp.com>
…scanworkflow [workflow] Call `scanWorkflow` concurrently Signed-off-by: Andrew Mason <amason@slack-corp.com>
add backup status to vtctld 9.0 branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This brings the following PRs into our vtctld deploy:
VtctldServer.GetWorkflowsmethod vitessio/vitess#8261scanWorkflowconcurrently vitessio/vitess#8272I also needed to commit a workaround to a type change in the
sqlparserpackage that we don't have yet, which just amounted to converting some strings to[]byte. For more details, see a4a5594I also opened another PR (#218) to merge this change into this branch, and we can merge the final result. It's not merged into upstream yet, so I wanted eyes on just that diff separately.