Replace vitess:base with vitess:lite images for docker-compose services#7004
Merged
sougou merged 6 commits intovitessio:masterfrom Nov 12, 2020
Merged
Replace vitess:base with vitess:lite images for docker-compose services#7004sougou merged 6 commits intovitessio:masterfrom
sougou merged 6 commits intovitessio:masterfrom
Conversation
Signed-off-by: jawabuu <49921621+jawabuu@users.noreply.github.com>
Signed-off-by: jawabuu <49921621+jawabuu@users.noreply.github.com>
Signed-off-by: jawabuu <49921621+jawabuu@users.noreply.github.com>
Signed-off-by: jawabuu <49921621+jawabuu@users.noreply.github.com>
Signed-off-by: jawabuu <49921621+jawabuu@users.noreply.github.com>
Signed-off-by: jawabuu <49921621+jawabuu@users.noreply.github.com>
shlomi-noach
reviewed
Nov 8, 2020
Contributor
shlomi-noach
left a comment
shlomi-noach
left a comment
There was a problem hiding this comment.
A couple questions inline for clarifications.
sougou
approved these changes
Nov 12, 2020
Contributor
sougou
left a comment
sougou
left a comment
There was a problem hiding this comment.
Nice work. I didn't verify that this works, but the changes look good. If we encounter new problems, we can always fix forward.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR replaces the huge
vitess: baseimages >2G with thevitess:liteimage.The objective is to make it quicker for someone to spin up a docker-compose example.
A secondary objective is to mirror operator design and discard the
InitShardMasterintroduced here by implementing orchestrator.@sougou @shlomi-noach @deepthi