Skip to content

vtcompose/docker-compose: fix InitShardMaster#6584

Merged
deepthi merged 1 commit intovitessio:masterfrom
planetscale:fix-docker-compose
Aug 18, 2020
Merged

vtcompose/docker-compose: fix InitShardMaster#6584
deepthi merged 1 commit intovitessio:masterfrom
planetscale:fix-docker-compose

Conversation

@shlomi-noach
Copy link
Copy Markdown
Contributor

Fixes #6521

This PR removes deprecated InitTablet and introduces InitShardMaster. This is done by:

  • running one docker
  • per shard
  • after all shard tablets are initialized
  • that executes InitShardMaster on the *01 tablet (e.g. test-201)

Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
Copy link
Copy Markdown
Collaborator

@deepthi deepthi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Can you create another PR that cherry-picks this onto release-7.0?

@deepthi deepthi merged commit 2d0f294 into vitessio:master Aug 18, 2020
@deepthi deepthi added this to the 7.0.1 milestone Aug 18, 2020
@shlomi-noach shlomi-noach deleted the fix-docker-compose branch August 18, 2020 14:08
@deepthi deepthi removed this from the 7.0.1 milestone Aug 18, 2020
@askdba askdba added this to the v8.0 milestone Oct 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

docker-compose example is broken

3 participants