Closed
Conversation
Signed-off-by: David Weitzman <dweitzman@pinterest.com>
Collaborator
|
I ran into this and included it in #6904. I'm holding off on merging anything right now until docker builds are fixed (and we can get CI green again). |
Collaborator
Collaborator
Author
|
This is out of date and some version of it is probably already merged, so closing it |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On motivation for this is that "github.com/google/shlex" is missing from the list of deps.
Seems like we should be building with
-mod=readonly, which would have caught this by refusing to allow unversioned dependenciesSigned-off-by: David Weitzman dweitzman@pinterest.com