healthcheck: use isIncluded correctly to fix replica/rdonly routing bug#6904
Merged
deepthi merged 2 commits intovitessio:masterfrom Oct 22, 2020
Merged
healthcheck: use isIncluded correctly to fix replica/rdonly routing bug#6904deepthi merged 2 commits intovitessio:masterfrom
deepthi merged 2 commits intovitessio:masterfrom
Conversation
Signed-off-by: deepthi <deepthi@planetscale.com>
Closed
sougou
approved these changes
Oct 21, 2020
go/vt/discovery/healthcheck.go
Outdated
| if shr.Target.TabletType != topodata.TabletType_MASTER { | ||
| // we re-sort the healthy tablet list whenever we get a health update for tablets we can route to | ||
| // tablets from other cells for non-master targets should not trigger a re-sort | ||
| // they should also be excluded from healthy list |
Contributor
There was a problem hiding this comment.
Need to fix punctuation (and caps). Took me a while to realize that each line is a separate sentence.
Collaborator
Author
There was a problem hiding this comment.
Apologies. I have fixed it now.
Signed-off-by: deepthi <deepthi@planetscale.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In a multi-cell scenario, we want to exclude REPLICA/RDONLY tablets in other cells from vtgate routing.
There was a bug in the logic in healthcheck that excludes these tablets. Whenever there was a healthcheck update for a tablet in "another" cell, all tablets in the healthy list were being dropped out.
Tested manually using a multi-cell cluster. An endtoend test will be added in a separate PR.
Signed-off-by: deepthi deepthi@planetscale.com