vrepl metrics: add metrics around vstreamer and vreplication metrics#6787
Merged
deepthi merged 3 commits intovitessio:masterfrom Oct 6, 2020
Merged
vrepl metrics: add metrics around vstreamer and vreplication metrics#6787deepthi merged 3 commits intovitessio:masterfrom
deepthi merged 3 commits intovitessio:masterfrom
Conversation
Signed-off-by: Rohit Nayak <rohit@planetscale.com>
Signed-off-by: Rohit Nayak <rohit@planetscale.com>
Signed-off-by: Rohit Nayak <rohit@planetscale.com>
rohit-nayak-ps
requested review from
harshit-gangal,
sougou and
systay
as code owners
deepthi
approved these changes
Oct 6, 2020
Collaborator
deepthi
left a comment
deepthi
left a comment
There was a problem hiding this comment.
LGTM. Can you add an example to the PR description of what the metrics look like?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Rohit Nayak rohit@planetscale.com