Skip to content

vtctld UI: Fix logic for displaying vindexes#6603

Merged
deepthi merged 1 commit intovitessio:masterfrom
planetscale:rn-ui-show-vindex-info
Aug 21, 2020
Merged

vtctld UI: Fix logic for displaying vindexes#6603
deepthi merged 1 commit intovitessio:masterfrom
planetscale:rn-ui-show-vindex-info

Conversation

@rohit-nayak-ps
Copy link
Copy Markdown
Member

Addressing issues raised in #6450

  • Fix: GetVSchema is now returning camelCase for vindexes/auto increment instead of snake_case.
  • Serialized vindex params to show json instead of the message

    Signed-off-by: Rohit Nayak rohit@planetscale.com

Signed-off-by: Rohit Nayak <rohit@planetscale.com>
@rohit-nayak-ps rohit-nayak-ps requested a review from sougou as a code owner August 20, 2020 22:01
@rohit-nayak-ps rohit-nayak-ps linked an issue Aug 20, 2020 that may be closed by this pull request
@deepthi
Copy link
Copy Markdown
Collaborator

deepthi commented Aug 21, 2020

Can you add a screenshot of the UI?

@rohit-nayak-ps
Copy link
Copy Markdown
Member Author

First screenshot is for the local example. Second and third. for region example.

Screenshot from 2020-08-21 11-54-24

Screenshot from 2020-08-21 12-35-16

Screenshot from 2020-08-21 12-35-33

Copy link
Copy Markdown
Collaborator

@deepthi deepthi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯 This is great!

@deepthi deepthi merged commit 628a823 into vitessio:master Aug 21, 2020
deepthi added a commit that referenced this pull request Aug 24, 2020
Reverting package-lock.json to the one pre-PR #6603
@askdba askdba added this to the v8.0 milestone Oct 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Show more vindex details in vtctld /app/schema UI

3 participants