Skip to content

Allow empty shards when validating schemas#6216

Merged
rafael merged 3 commits intovitessio:masterfrom
tinyspeck:fixes-issue-with-validate-keyspace
Jun 2, 2020
Merged

Allow empty shards when validating schemas#6216
rafael merged 3 commits intovitessio:masterfrom
tinyspeck:fixes-issue-with-validate-keyspace

Conversation

@rafael
Copy link
Copy Markdown
Member

@rafael rafael commented May 22, 2020

Description

  • We have some cases where we have a valid keyspace that has empty shards. In those cases, we can't use this command because it fails in the empty shards.
  • This is a behavior that is probably very specific to Slack, but seems like is harmless as is behind flag of the command.

Signed-off-by: Rafael Chacon <rafael@slack-corp.com>
@rafael rafael requested a review from sougou as a code owner May 22, 2020 21:46
@rafael rafael requested a review from deepthi May 22, 2020 21:47
Rafael Chacon added 2 commits June 1, 2020 15:17
* We don't need to check the schema when reference == reference.

Signed-off-by: Rafael Chacon <rafael@slack-corp.com>
Signed-off-by: Rafael Chacon <rafael@slack-corp.com>
Copy link
Copy Markdown
Collaborator

@deepthi deepthi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rafael rafael merged commit 19fdf8b into vitessio:master Jun 2, 2020
ajm188 pushed a commit to tinyspeck/vitess that referenced this pull request Jun 26, 2020
…date-keyspace

Allow empty shards when validating schemas
@deepthi deepthi added this to the v7.0 milestone Jul 27, 2020
ameetkotian pushed a commit to tinyspeck/vitess that referenced this pull request Aug 19, 2020
…date-keyspace

Allow empty shards when validating schemas
@rafael rafael deleted the fixes-issue-with-validate-keyspace branch May 25, 2021 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants