This repository was archived by the owner on Dec 16, 2022. It is now read-only.
Conversation
added 3 commits
June 2, 2020 10:18
Signed-off-by: Rafael Chacon <rafael@slack-corp.com>
* We don't need to check the schema when reference == reference. Signed-off-by: Rafael Chacon <rafael@slack-corp.com>
Signed-off-by: Rafael Chacon <rafael@slack-corp.com>
setassociative
approved these changes
Jun 2, 2020
setassociative
left a comment
setassociative
left a comment
There was a problem hiding this comment.
nit: I would have called this branch slack-vitess-2020.04.28.r1 or something (whatever our last release branch was + 1 on r<number>.
Not a real concern though since we don't use this directly / can tag it as both if we want it to be discoverable later
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description